-
Notifications
You must be signed in to change notification settings - Fork 4
Changed Asset images to System images #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
joeljfischer
merged 16 commits into
develop
from
feature/issue-17-replace-internal-images-with-ios-system-images
Aug 19, 2021
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
b0451a0
Asset images to system images
1ada557
Code update
70e0dc0
Code update
99d9261
Comments update
cc7c57d
Comments review
ff9b1f9
ImageSize update
9a5bee2
ImageProcessor update
9dba30b
Merge branch 'develop' into feature/issue-17-replace-internal-images-…
joeljfischer a91132d
ImageProcessor update
ce9d458
Comments review
44e8c6a
Image processor update
a22f1d8
artworkFromConditionImage update
465d5f2
main.storyboard update
acbfe13
conditionImage content mode update
fdedb5a
unused method update
4d185a4
conditionIcon size edit
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| // | ||
| // ImageSize.h | ||
| // MobileWeather | ||
| // | ||
| // Created by Frank Elias on 6/28/21. | ||
| // Copyright © 2021 Ford. All rights reserved. | ||
| // | ||
|
|
||
| @import UIKit; | ||
|
|
||
| typedef NS_ENUM(NSUInteger, ImageSize) { | ||
| ImageSizeLarge, | ||
| ImageSizeSmall | ||
| }; | ||
|
|
||
| @interface ImageSizeHelper : NSObject | ||
|
|
||
| + (CGFloat)floatForImageSize:(ImageSize)imageSize; | ||
|
|
||
| @end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| // | ||
| // ImageSize.m | ||
| // MobileWeather | ||
| // | ||
| // Created by Frank Elias on 6/28/21. | ||
| // Copyright © 2021 Ford. All rights reserved. | ||
| // | ||
|
|
||
| #import "ImageSize.h" | ||
|
|
||
| @implementation ImageSizeHelper | ||
|
|
||
| + (CGFloat)floatForImageSize:(ImageSize)imageSize { | ||
| if (imageSize == ImageSizeLarge) { | ||
| return 256; | ||
| } else { | ||
| return 64; | ||
| } | ||
| } | ||
|
|
||
| @end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "info" : { | ||
| "version" : 1, | ||
| "author" : "xcode" | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } | ||
| } |
21 changes: 0 additions & 21 deletions
21
MobileWeather/Images.xcassets/Images/chancerain.imageset/Contents.json
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-13.5 KB
MobileWeather/Images.xcassets/Images/chancerain.imageset/chancerain.png
Binary file not shown.
21 changes: 0 additions & 21 deletions
21
MobileWeather/Images.xcassets/Images/chancesnow.imageset/Contents.json
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-14.4 KB
MobileWeather/Images.xcassets/Images/chancesnow.imageset/chancesnow.png
Binary file not shown.
21 changes: 0 additions & 21 deletions
21
MobileWeather/Images.xcassets/Images/clear-day.imageset/Contents.json
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-11.3 KB
MobileWeather/Images.xcassets/Images/clear-day.imageset/clear-day.png
Binary file not shown.
21 changes: 0 additions & 21 deletions
21
MobileWeather/Images.xcassets/Images/clear-night.imageset/Contents.json
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-7.75 KB
MobileWeather/Images.xcassets/Images/clear-night.imageset/clear-night.png
Binary file not shown.
21 changes: 0 additions & 21 deletions
21
MobileWeather/Images.xcassets/Images/cloudy.imageset/Contents.json
This file was deleted.
Oops, something went wrong.
Binary file not shown.
21 changes: 0 additions & 21 deletions
21
MobileWeather/Images.xcassets/Images/flurries.imageset/Contents.json
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-15.8 KB
MobileWeather/Images.xcassets/Images/flurries.imageset/flurries.png
Binary file not shown.
21 changes: 0 additions & 21 deletions
21
MobileWeather/Images.xcassets/Images/fog.imageset/Contents.json
This file was deleted.
Oops, something went wrong.
Binary file not shown.
21 changes: 0 additions & 21 deletions
21
MobileWeather/Images.xcassets/Images/hazy.imageset/Contents.json
This file was deleted.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.