Repository navigation
chore: ⚡️️ Preemptively account for invalid input buffer and 🐛 don't send error if already sent - #409
Merged
vatsaltanna-simformsolutions merged 1 commit intoMay 22, 2025
Conversation
ujas-m-simformsolutions
force-pushed
the
fix/check_invalid_input_buffer
branch
from
April 16, 2025 08:39
126e270 to
b991b0d
Compare
| private var pcmEncodingBit = 16 | ||
| private var totalSamples = 0L | ||
| private var perSamplePoints = 0L | ||
| private var hasRepliedSubmitted = false |
Collaborator
There was a problem hiding this comment.
Variable name can be improved. isReplySubmitted or hasSubmittedReply
ujas-m-simformsolutions
force-pushed
the
fix/check_invalid_input_buffer
branch
2 times, most recently
from
May 21, 2025 13:21
8913a75 to
7f861bc
Compare
…send error if already sent
ujas-m-simformsolutions
force-pushed
the
fix/check_invalid_input_buffer
branch
from
May 22, 2025 09:33
7f861bc to
99df265
Compare
vatsaltanna-simformsolutions
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to fix #375 and #376