Skip to content

Workflows first run: keep the product welcome modal off the gallery #273

Closed

Description

@Silthus

Map: Map: build the Workflows first run, from template gallery to first send
Spec: Spec: Workflows first run

Cast: Opus 5.5 (UI)

Graduated from a follow-up on the tailored template gallery (PostHog#111816).

Question

Does the first run's gallery open without another welcome modal on top of it?

Delivers end to end. With workflows-first-run on, the nav-panel product push welcome modal (frontend/src/lib/components/NavPanelAdvertisement) can open over the gallery. The gallery is itself the welcome. While the first run shows (flag on, project without workflows), that modal does not open on the Workflows tab. Elsewhere, and with the flag off, nothing changes.

Test seams. A kea logic test at the modal's own decision point: it stays closed while the first-run gallery is showing, and opens as before otherwise.

Write scope. frontend/src/lib/components/NavPanelAdvertisement/ (the smallest hook that lets a scene suppress it), the first-run folder under products/workflows/frontend/, and tests. Keep the suppression generic rather than naming Workflows inside the shared component.

Acceptance criteria

  • Flag on, project without workflows: the gallery opens with no welcome modal over it.
  • Flag off, or a project with workflows: the modal behaves as on master.

How to build (map #253)

Activity

  1. Silthus commented on Oct 5, 2026

    @Silthus
    OwnerAuthor

    Runtime: Claude Code background agent (conductor thread on devbox-michaelr-3)
    Worker: impl-273, Claude Opus 5.5 (routine UI)
    Worktree: /home/coder/.t3/worktrees/posthog/fr-273, branch feat/workflows-first-run-quiet-welcome-modal, stacked on PostHog#111816
    Cap: 4 hours from 12:27 UTC
    CodeRabbit slot: 2 of 3

  2. Silthus commented on Oct 5, 2026

    @Silthus
    OwnerAuthor

    Worker transcript: /tmp/claude-1001/-home-coder--t3-worktrees-posthog-t3code-1d6de0ea/6f4018e1-a32c-4b89-bae8-f0ca1d7056a8/tasks/a66edf81c3b56c087.output. Deadline wake set for 16:31 UTC.

  3. self-assigned this
    on Oct 5, 2026
  4. Silthus commented on Oct 5, 2026

    @Silthus
    OwnerAuthor

    Claimed by conductor worker impl-273 (Claude Code background agent, Opus 5.5).

  5. Silthus commented on Oct 5, 2026

    @Silthus
    OwnerAuthor

    Lane interrupted: the worker stopped on a provider overload (HTTP 529) after confirming its red test. Uncommitted work-in-progress is intact in /home/coder/.t3/worktrees/posthog/fr-273 (shared logic and first-run hold logic, tests). Resuming the same worker impl-273 with its context; cap and CodeRabbit slot 2 unchanged.

  6. Silthus commented on Oct 5, 2026

    @Silthus
    OwnerAuthor

    Orchestration blocker: the resumed worker failed again at once on provider overload (HTTP 529) for Claude Opus 5.5, the map's cast for routine UI. Lane orphaned; work-in-progress stays uncommitted in /home/coder/.t3/worktrees/posthog/fr-273. CodeRabbit slot 2 released. Asking Michael whether to wait for Opus 5.5 or recast this slice.

  7. Silthus commented on Oct 5, 2026

    @Silthus
    OwnerAuthor

    Recast (Michael, 2026-10-05): the Opus 5.5 worker stopped on provider overload or rate limit. Continuing on GPT-6.1 Sol through a Claude Code codex:codex-rescue background agent, worker impl-273-gpt, in the same worktree /home/coder/.t3/worktrees/posthog/fr-273. Cap: 4 hours from 13:24 UTC. CodeRabbit slot: 2 of 3.

  8. Silthus commented on Oct 5, 2026

    @Silthus
    OwnerAuthor

    Worker transcript (codex-rescue bridge agent): /tmp/claude-1001/-home-coder--t3-worktrees-posthog-t3code-1d6de0ea/6f4018e1-a32c-4b89-bae8-f0ca1d7056a8/tasks/aee97b16e743ca196.output. Deadline wake set for 17:29 UTC.

  9. Silthus commented on Oct 5, 2026

    @Silthus
    OwnerAuthor

    Lane orphaned: the codex:codex-rescue bridge runs Codex in a sandbox without network or the flox environment, so it could not reach GitHub, push, or run the gate. No changes were made; the worktree WIP is intact. Redispatching as a T3 delegated child on GPT-6.1 Sol with full access, the path that shipped #257. Worker impl-273-gpt-r2. Cap: 4 hours from 13:26 UTC.

  10. Silthus commented on Oct 5, 2026

    @Silthus
    OwnerAuthor

    Runtime: T3 delegated child
    Task: node:delegated-task:command%3Amcp%3A76836cff-6bc5-4020-b351-b1d68e6aaa47%3Adelegate-task%3Afr-273-r2
    Deadline wake: 17:29 UTC

  11. Silthus commented on Oct 5, 2026

    @Silthus
    OwnerAuthor

    Note

    🤖 GPT-6.1 Sol responding on behalf of Michael

    Taking over as impl-273-gpt-r2 in the existing branch. The test seam remains the welcome modal’s kea decision point, with a generic scene hold. The next report will link the draft PR, red/green proof, local gate, gallery screenshot, and QA handoff, or record one pending decision.

  12. Silthus commented on Oct 5, 2026

    @Silthus
    OwnerAuthor

    Note

    🤖 GPT-6.1 Sol responding on behalf of Michael

    Shipped in draft PostHog/posthog#111923, stacked on PostHog#111816. Clean head: 4e143b0fd52bcff72b7dd9d578966a2f00336271. The gallery holds the shared welcome through setup detection and display; existing-workflow and flag-off visits retain the welcome behavior.

    Proof bundle includes the original red tests, the same tests green, automatic-opening mutation proof, full frontend typecheck/fix, eight affected Jest suites, strict preflight, actual pre-push hooks, and before/after/narrow gallery screenshots. The final local gate passed.

    QA handoff: two rounds, eight native GPT-6.1 Sol lenses per round. One test finding fixed; the second round is clean. No decision remains open. Merge risk is low.

    • Calls made: preserve the pending click, hold during detection, use product-local lifecycle callbacks, and requeue a modal that opened before its holder mounted.
    • Follow-up: the lazy App shell can briefly show the welcome before the gallery mounts. The holder removes it before gallery display; shell readiness lies outside this ticket's write scope.
    • Gaps: upstream fork CI awaits maintainer approval, as accepted by map Map: build the Workflows first run, from template gallery to first send #253. CodeRabbit CLI was signed out and skipped; remote review stayed silent during observation. The requested all-GPT panel replaces the complementary family. T3 preview was unavailable, so headless Playwright supplied proof. Screenshot upload and PR assignment lacked permission; images are on the fork proof branch.

    Closing #273 with the draft ready for Michael's review. The PR stays draft; no queue or merge action was taken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions