Repository navigation
feat(pr-description): record each decision as a question, answer and who decided it - #9
Merged
Merged
Conversation
…who decided it The Decisions table credited the agent with calls the user made and could not tell an override from an accepted recommendation. Rows now record the question and its answer, Who has three classes (👤 Human, 👍 Accepted default, 🤖 Agent), unanswered questions go on an Open line, and decisions are kept as decision lines where they are made. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… on the map Address review findings: decision lines live under Who with a generic mark, a later line for the same question wins, feedback that changed a draft makes it 👤, charting answers land on the map, and ship and implementation calls are written as decision lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ines Final-read findings: AFK task, research, prototype and spec workers now record their own calls as decision lines too, the charting rule covers every decision locked while charting, and review rows take their mark from pr-description. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ines Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Decisions block of a PR could not say who really decided. Two things went wrong:
On PostHog/posthog#118924 this credited the agent with a send route the user picked over its recommendation. It also listed an unanswered question as a finished call.
Merge Danger
🟢 Low, two-way door. The change is to skill text only.
pr-descriptionand orchestration-wayfinder rely on the newfleet decisionsoutput (Silthus/fleet4025fdeand706b16c, onmainand rolled out), which reads the decision lines these skills now ask for. Maps that have no decision lines yet printNo load-bearing decisions., so the block for them is written by hand from the transcript.Summary
pr-description: the Decisions table has the columns Question, Answer, Who and Where, with one row per decision, never one per ticket. Who has three classes:Rows sort in that order. An unanswered question goes on an Open line and blocks the PR. Decisions are recorded where they are made as decision lines:
- 👤 **<question>** <answer>.orchestration-wayfinder:
architecture: the resolution comment lists locked decisions as decision lines.Evidence
bun run check: 74 tests pass.fleet decisionsis tested in Silthus/fleet (src/decisions.test.ts).Decisions
fleet decisions, three-class schema, Open linegrillingwrite decision lines?Involvement: 1 review round and 3 final reads (Opus 5.5);
fleet proof gatepasses on HEAD.🤖 Generated with Claude Code