Repository navigation
fix: avoid UnboundLocalError in SigmaFilter.from_dict with collect_errors=True - #544
Merged
thomaspatzke merged 1 commit intoSep 20, 2026
Conversation
…rors=True When both the logsource and filter fail to parse and collect_errors=True, the local variables were never assigned, so cls() raised an UnboundLocalError instead of returning the collected errors.
thomaspatzke
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SigmaFilter.from_dict(..., collect_errors=True)is meant to collect parsingerrors into
.errorsinstead of raising, so callers can report every problemin a filter definition at once. When both the
logsourceandfiltersections fail to parse, the local variables
filter_logsourceandfilter_global_filterare never assigned before being passed tocls(...),so an
UnboundLocalErroris raised instead — even withcollect_errors=True.Fix
Assign the placeholder values used elsewhere in the codebase for this exact
situation (
EmptyLogSource, matching the pattern already used inSigmaRule.from_dict) in eachexceptbranch, plus a newEmptySigmaGlobalFilterplaceholder mirroringEmptySigmaDetections, so theobject can still be constructed while the real errors are recorded in
.errors.Test plan
test_sigmafilter_collect_errorsandtest_sigmafilter_collect_errors_false_raisesintests/test_filters.py.pytest tests/test_filters.py tests/test_correlations.pypasses (119 passed, 1 skipped).test_plugins.py).