ensure request ids contain alphanumerics,dashes,underscores#23
Merged
topherbullock merged 1 commit intomainfrom Oct 28, 2025
Merged
ensure request ids contain alphanumerics,dashes,underscores#23topherbullock merged 1 commit intomainfrom
topherbullock merged 1 commit intomainfrom
Conversation
prevent potential for XSS by rejecting ids with special characters allow passing a validation pattern to override the default id validations
topherbullock
force-pushed
the
validate-request-id-formatting
branch
from
3661b11 to
a5cf618
Compare
atesgoral
approved these changes
Oct 28, 2025
Merged
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ID validation to prevent XSS vulnerabilities
This PR adds string ID validation to protect against XSS vulnerabilities when request IDs are reflected in responses. By default, string IDs are now validated to contain only alphanumeric characters, dashes, and underscores; this prevents users from sending HTML content that is reflected back in responses. Reflecting raw ids with HTML content in responses opens a vector for XSS if proper content type validations are not also applied.
The validation pattern can be customized by passing an
id_validation_patternparameter tohandleorhandle_jsonmethods:/\A[a-zA-Z0-9_-]+\z/nilto accept any string ID (not recommended)The README has been updated with examples showing how to use and customize the ID validation.