Merged
Conversation
… tool_calls are present
vipul-mittal
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐞 Bug Fix
📋 Summary
This PR fixes a bug in the
inject_history_multiturnfunction in thellm_nodethat caused crashes when processing assistant messages without tool calls in multi-turn conversations.Issue:
When an assistant response in chat history didn't contain tool calls (empty list []), the code attempted to convert the empty list to LangChain tool calls, causing a ValueError: Expected 'function' key in OpenAI tool call error in the
convert_openai_to_langchain_toolcall function.
Fix:
Added validation checks to ensure tool_calls_data contains items before attempting conversion:
🔧 Impacted Components
llm_node.inject_history_multiturn— method now correctly handles assistant messages without tool calls🧪 How to Test
📸 Screenshots
N/A
✅ Checklist
Notes
N/A