Skip to content

[Fix] Fix lambda node failures#67

Merged
psriramsnc merged 1 commit intomainfrom
scratch/lambda_node_metadata_fix
Dec 1, 2025
Merged

[Fix] Fix lambda node failures#67
psriramsnc merged 1 commit intomainfrom
scratch/lambda_node_metadata_fix

Conversation

@psriramsnc
Copy link
Collaborator

@psriramsnc psriramsnc commented Nov 28, 2025

Summary (Bug Fix)

This PR fixes multiple issues in the LambdaNode execution path and LangGraph backend integration:

  • LambdaNode was not passing node_config to func_to_execute, causing unexpected runtime errors.
  • vLLM model config attribute mismatch (model_serving_name vs model_name) caused failing tests and incorrect initialization.
    This PR standardizes it and updates tests accordingly.

🔧 Impacted Components

  • 🧠 LambdaNode._exec_wrapper — now correctly calls func_to_execute(node_config, state)
  • 🔌 BackendFactory & LangGraphFactory — fixed API mismatch, now accept exec_wrapper only
  • 🚀 LiteLLMVLLM — fixes incorrect attribute name leading to wrong model initialization & test failures

🧪 How to Test

  1. Run unit tests:
    make test-verbose
  2. Create a simple LambdaNode and run:
  • Ensure the function receives both node_config and state
  • Validate LangGraph runnable executes without errors
  1. Initialize LiteLLMVLLM with and without model_serving_name:
  • Confirm model_name is populated correctly
  • Updated tests in test_litellm_vllm.py should pass

📸 Screenshots

N/A

✅ Checklist

  • Lint fixes and unit testing done
  • End to end task testing
  • Documentation updated

Notes

This PR unblocks LambdaNode execution and standardizes backend runnable handling.
No external API changes expected for end users.

@psriramsnc psriramsnc marked this pull request as ready for review November 28, 2025 13:57
@psriramsnc psriramsnc requested a review from a team as a code owner November 28, 2025 13:57
@psriramsnc psriramsnc self-assigned this Nov 28, 2025
@psriramsnc psriramsnc changed the title Fix lambda node failures [Fix] Fix lambda node failures Nov 28, 2025
@psriramsnc psriramsnc added the bug Something isn't working label Nov 28, 2025
Copy link
Collaborator

@amitsnow amitsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@psriramsnc psriramsnc merged commit a85f259 into main Dec 1, 2025
4 checks passed
@psriramsnc psriramsnc deleted the scratch/lambda_node_metadata_fix branch December 1, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants