[Enhancement] Adding aggregator metrics to platform for generic or task specific usage #66
Merged
vipul-mittal merged 27 commits intomainfrom Dec 11, 2025
Merged
[Enhancement] Adding aggregator metrics to platform for generic or task specific usage #66vipul-mittal merged 27 commits intomainfrom
vipul-mittal merged 27 commits intomainfrom
Conversation
…trics for downstream tasks
bidyapati-p
reviewed
Dec 2, 2025
psriramsnc
reviewed
Dec 2, 2025
Collaborator
psriramsnc
left a comment
psriramsnc
left a comment
There was a problem hiding this comment.
Should we follow the structure /sygra/core/eval/metrics instead?
Please look into other comments.
sygra/core/metrics/aggregator_metrics/base_aggregator_metric.py
Outdated
Show resolved
Hide resolved
Member
|
As it is a public facing repository, let's refrain from mentioning internal references (the PR description points to an internal Lucidchart document). Please remove it. |
zephyrzilla
previously requested changes
Dec 2, 2025
…decoupling for generalization, pydantic metadata base class for easier re-usability, extendibility and separation of concern
…ion, in-class pydantic config validation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
bidyapati-p
previously approved these changes
Dec 8, 2025
omkar-anustoop-ai
requested review from
a team,
bidyapati-p,
psriramsnc and
zephyrzilla
and removed request for
bidyapati-p,
psriramsnc and
zephyrzilla
bidyapati-p
approved these changes
Dec 11, 2025
vipul-mittal
dismissed
zephyrzilla’s stale review
Already taken care of the requested changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for aggregator metrics and some unit metrics as discussed in the finalised design. The implementation provides industry-standard evaluation metrics with a clean, extensible architecture.
Explain the features implemented:
Aggregator Metrics (Industry Standard)
Unit Metrics (Validators)
Supporting Infrastructure
Performance impact (if any):
N/A - New feature with no impact on existing functionality.
How to Test the feature
poetry run pytest tests/core/eval/metrics/ -vScreenshots (if applicable)
N/A
Checklist
Notes
Corresponding unit tests and documentation have been added for reference and usage purposes. The architecture supports easy addition of new metrics following the established patterns.