Skip to content

[Bugfix] Fix for Nested Subgraphs#4

Merged
amitsnow merged 6 commits intomainfrom
scratch/nested_subgraphs
Aug 21, 2025
Merged

[Bugfix] Fix for Nested Subgraphs#4
amitsnow merged 6 commits intomainfrom
scratch/nested_subgraphs

Conversation

@amitsnow
Copy link
Collaborator

Summary

This PR introduces a refactor for edge configuration handling and an enhancement to nested subgraph node resolution.

  • Updated _get_node logic to support nested subgraph lookups, ensuring nodes can be resolved correctly when prefixed or referenced across subgraphs.
  • Updated test_graph_config.py

The purpose of this PR is to make edge creation and node resolution is more robust.

Related Issue(s):

Impacted Features:

N/A

How to Test

Screenshot 2025-08-20 at 3 01 10 AM Create a subgraph similar to the following image

Expected Result:

  • No failures and the graph should compile

Screenshots (if applicable)

N/A (backend-only changes)

Checklist

  • Lint fixes and unit testing done
  • End to end task testing
  • Documentation updated

@amitsnow amitsnow changed the title Scratch/nested subgraphs [Bugfix] Fix for Nested Subgraphs Aug 19, 2025
@psriramsnc psriramsnc self-requested a review August 21, 2025 04:26
psriramsnc
psriramsnc previously approved these changes Aug 21, 2025
@vipul-mittal vipul-mittal enabled auto-merge (squash) August 21, 2025 05:39
zephyrzilla
zephyrzilla previously approved these changes Aug 21, 2025
@zephyrzilla
Copy link
Member

Overall looks good to me, except some minor comments. Approved.

@amitsnow amitsnow disabled auto-merge August 21, 2025 08:18
@amitsnow amitsnow dismissed stale reviews from zephyrzilla and psriramsnc via 8af83de August 21, 2025 09:35
Copy link
Collaborator

@psriramsnc psriramsnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amitsnow amitsnow merged commit 160d741 into main Aug 21, 2025
@amitsnow amitsnow deleted the scratch/nested_subgraphs branch August 21, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fully nested subgraphs fail

4 participants