Skip to content

[Enhancement] Add Lint Checks#31

Merged
vipul-mittal merged 12 commits intomainfrom
scratch/add_lint_checks
Sep 15, 2025
Merged

[Enhancement] Add Lint Checks#31
vipul-mittal merged 12 commits intomainfrom
scratch/add_lint_checks

Conversation

@psriramsnc
Copy link
Collaborator

@psriramsnc psriramsnc commented Sep 11, 2025

📋 Summary

This PR introduces a GitHub Actions workflow for linting and also fixes existing linting issues across the codebase.

🔧 Changes

  • Added Lint workflow:
    • Runs on pushes to main
    • Runs on pull requests (excluding drafts)
    • Uses Poetry + cached virtualenv for dependencies
    • Runs make lint to enforce code style
  • Fixed all existing linting errors in the repository to ensure the workflow passes from the start

✅ Benefits

  • Ensures consistent coding style across all contributions
  • Prevents new linting issues from entering main
  • Clean baseline: no pre-existing lint errors
  • Faster feedback cycle with cached Poetry environment

📌 Notes

  • Developers should run make lint locally before pushing.
  • Future lint errors will cause PR checks to fail until fixed.

Performance impact (if any):

N/A

How to Test the feature

Run make lint

Screenshots (if applicable)

N/A

Checklist

  • Lint fixes and unit testing done
  • End to end task testing
  • Documentation updated

Notes

N/A

@psriramsnc psriramsnc self-assigned this Sep 11, 2025
@psriramsnc psriramsnc marked this pull request as ready for review September 13, 2025 11:10
@psriramsnc psriramsnc requested a review from a team as a code owner September 13, 2025 11:10
@psriramsnc psriramsnc changed the title Fix Lint issues [Enhancement] Add Lint Checks Sep 13, 2025
@psriramsnc psriramsnc added the enhancement New feature or request label Sep 13, 2025
@vipul-mittal vipul-mittal enabled auto-merge (squash) September 13, 2025 13:19
Copy link
Collaborator

@amitsnow amitsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@vipul-mittal vipul-mittal merged commit 2d6285d into main Sep 15, 2025
4 checks passed
@vipul-mittal vipul-mittal deleted the scratch/add_lint_checks branch September 15, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants