Skip to content

Fix pydantic v2 issues#30

Merged
amitsnow merged 5 commits intomainfrom
scratch/pydantic_v2
Sep 11, 2025
Merged

Fix pydantic v2 issues#30
amitsnow merged 5 commits intomainfrom
scratch/pydantic_v2

Conversation

@amitsnow
Copy link
Collaborator

Summary

Fix failures due to pydantic while running oasst_mapper tool and replace dict() with model_dump() for removing pydantic v2 deprecation warnings

Related Issue(s):

Impacted Features:

  • OASST format data generation
  • Pydantic dict() deprecation warning while running any pipeline e2e

How to Test

Steps for reviewers to verify functionality:

  • Run OASST mapper tool. It should run successfully without any pydantic warnings or errors
  • Run any task e2e and it should run sucessfully without any pydantic dict() deprecation warnings

Screenshots (if applicable)

N/A

Checklist

  • Lint fixes and unit testing done
  • End to end task testing
  • Documentation updated

@amitsnow amitsnow requested a review from a team as a code owner September 11, 2025 14:48
Copy link
Collaborator

@psriramsnc psriramsnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@amitsnow amitsnow merged commit 6f99a1a into main Sep 11, 2025
3 checks passed
@amitsnow amitsnow deleted the scratch/pydantic_v2 branch September 11, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OASST tool fails to run

3 participants