Update Bug#18392#31
Merged
beltoforion merged 1 commit intomasterfrom May 21, 2025
Merged
Conversation
Contributor
|
ok |
HocaChen
approved these changes
May 20, 2025
Simon1224
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation of the swap bridge remote command seems incopmplete or outdated.
It lists two parameters:
Swap Bridge Side Rught/Left/Current/up/Down
Device Position: Up/Down
The device position is not a position but a direction or rather a DeviceMotionDirection.
From the implementation in SENTIO i conclude that the parameters have been merged into a single enum and a new integer parameter has been added. The documentation does not mention this.
The python API for the swap bridge should be updated too:
Use an enumerator as the parameter (or two if that is what the remote command requires)
add the integer parameter (delay time)