Skip to content

[codex] update MiniMax M3 FP8 MI355X vLLM MTP image#1941

Merged
functionstackx merged 1 commit into
mainfrom
codex/minimax-m3-fp8-mi355x-vllm-mtp-nightly
Jun 26, 2026
Merged

[codex] update MiniMax M3 FP8 MI355X vLLM MTP image#1941
functionstackx merged 1 commit into
mainfrom
codex/minimax-m3-fp8-mi355x-vllm-mtp-nightly

Conversation

@functionstackx

Copy link
Copy Markdown
Collaborator

What changed

  • update minimaxm3-fp8-mi355x-vllm-mtp from vllm/vllm-openai-rocm:minimax-m3 to the immutable vllm/vllm-openai-rocm:nightly-3f5a1e1733200760169ff31ebe60a271072b199e image
  • append the required performance changelog trigger

Why

This moves the MiniMax-M3 MXFP8 MI355X EAGLE3 sweep onto the same current ROCm nightly used by the MXFP4 coverage while keeping its draft model, serving flags, and search space unchanged.

Validation

  • generated 53 filtered MTP entries with the requested image
  • python -m pytest utils/matrix_logic/ -q (180 passed)

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers.

If additional help is needed, PR authors can reach out to core maintainers over Slack.


感谢你的贡献!对于 vLLM 与 SGLang,请确保你的 recipe 与官方 vLLM recipes 和/或 SGLang cookbook 保持一致

如果不一致,请先创建一个 PR,之后我们才能将你的单节点 PR 合并到 master 分支。让我们确保文档保持一流水准,使整个 ML 社区都能从你的辛勤工作中受益!谢谢

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。如果选择重新运行失败的任务,PR 作者有责任确保其最终通过。参见 GitHub 关于重新运行失败任务的文档:https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

一般而言,PR 作者应先向相应公司的 CODEOWNERS 请求审阅并获得 PR 批准,然后再请求核心维护者审阅。

如需更多帮助,PR 作者可通过 Slack 联系核心维护者。

@functionstackx functionstackx force-pushed the codex/minimax-m3-fp8-mi355x-vllm-mtp-nightly branch from 3613f2c to d0ad16d Compare June 26, 2026 02:13
@functionstackx functionstackx marked this pull request as ready for review June 26, 2026 02:13
@functionstackx functionstackx requested a review from a team June 26, 2026 02:13
@claude

claude Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Claude finished @functionstackx's task in 24s —— View job


Review: update MiniMax M3 FP8 MI355X vLLM MTP image

  • Read PR diff vs origin/main
  • Validate master-config image change
  • Validate perf-changelog.yaml update & placement

Findings

LGTM — no blocking issues found.

Checks performed:

  • Image accessibility ✅ — vllm/vllm-openai-rocm:nightly-3f5a1e1733200760169ff31ebe60a271072b199e is a public Docker Hub image and pins to an immutable digest-tagged nightly. Good move off the mutable :minimax-m3 tag.
  • Perf-changelog required & placement ✅ — amd-master.yaml was modified and perf-changelog.yaml has a matching entry, correctly appended to the end of the file with a valid pr-link.
  • Config-key consistency ✅ — only the image: field of the existing minimaxm3-fp8-mi355x-vllm-mtp key changed; model, draft model, serving flags, and search space are untouched, consistent with the PR description.

Comment thread .github/configs/amd-master.yaml
@github-actions

Copy link
Copy Markdown
Contributor

@functionstackx functionstackx merged commit 0cfa930 into main Jun 26, 2026
111 of 116 checks passed
@functionstackx functionstackx deleted the codex/minimax-m3-fp8-mi355x-vllm-mtp-nightly branch June 26, 2026 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

1 participant