[codex] Remove associated PR changelog validation#1852
Merged
Conversation
Contributor
|
Claude finished @Oseltamivir's task in 28s —— View job Review
LGTM - no blocking issues found. The removal is clean: the workflow step and its dedicated regression test are fully excised with no dangling references or orphaned code. |
Klaud-Cold
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate the associated pull requeststep fromtest-changelog-gate.ymlrun-sweep.ymlchangelog validation unchangedReason
The test workflow began validating the full associated PR diff on every relevant branch push. After a stale PR merged current
main, this extra check rejected its changelog entry placement even though the workflow’s validator and gating test suite passed. This removes that recently added cross-PR validation from the test workflow.Impact
Test Changelog Gatecontinues to run the validator, reuse, gating, and historical fixture tests. Actual sweep runs continue to validateperf-changelog.yamlthroughrun-sweep.yml.Validation
actionlint .github/workflows/test-changelog-gate.ymlgit diff --checkNote
Low Risk
CI-only change to a test workflow; production sweep changelog gating in
run-sweep.ymlis explicitly unchanged.Overview
Removes the Validate the associated pull request step from
Test Changelog Gate, so branch pushes no longer runvalidate_perf_changelog.pyagainst the full open PR diff (base...HEAD) for the commit’s linked PR.That step was added recently and could fail when a stale PR rebased onto current
main—for example rejecting changelog entry placement even when the workflow’s pytest suite and historical fixture checks still passed.The workflow keeps pytest coverage, historical push validation fixtures, and the unchanged changelog checks in
run-sweep.yml. The regression test that asserted the removed step’sperf-changelog.yamlskip behavior is deleted with it.Reviewed by Cursor Bugbot for commit 68bfcf6. Bugbot is set up for automated code reviews on this repo. Configure here.