[Klaud Cold] MI300X MiniMax-M3 nightly image and FP8 KV cache#1837
Conversation
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you
PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. |
1 similar comment
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you
PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. |
e8da035 to
37812d6
Compare
|
/reuse-sweep-run |
37812d6 to
5ab2002
Compare
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=27793464928 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=27794193147 |
|
/reuse-sweep-run |
Sync the branch with the latest upstream main (fork main force-synced to upstream). Resolve the perf-changelog.yaml conflict by taking main's version and re-appending the branch's own minimaxm3-fp8-mi300x-vllm AITER entry at the tail. The AITER target benchmarks/single_node/fixed_seq_len/minimaxm3_fp8_mi300x.sh auto-merged cleanly (main's SemiAnalysisAI#1837 image/FP8-KV change was reverted by SemiAnalysisAI#1857, so main's net change to that file is zero); the AITER env exports are preserved. Co-authored-by: Cursor <cursoragent@cursor.com>
What changed
minimaxm3-fp8-mi300x-vllmtovllm/vllm-openai-rocm:nightly-b53b1c7ffe7aebdafd0876350f30e51d1226c92a--kv-cache-dtype fp8chi-mi300x-121from Slurm allocationWhy
Use the updated ROCm vLLM build and reduce KV-cache memory use for the MI300X MiniMax-M3 sweep. The node exclusion prevents Pyxis failures on a node missing required Enroot/RAID provisioning.
Validation
Note
Medium Risk
FP8 KV cache shifts memory/accuracy behavior for a recipe that previously documented BF16 KV to avoid bad FP8 attention scales; the nightly image pin also changes the serving stack for benchmark comparability.
Overview
Updates the MI300X MiniMax-M3 MXFP8 vLLM benchmark to a pinned ROCm nightly (
vllm/vllm-openai-rocm:nightly-b53b1c7…) and turns on--kv-cache-dtype fp8inminimaxm3_fp8_mi300x.sh, replacing the prior BF16 KV default that avoided uncalibrated ROCm FP8 attention scales.Slurm allocation for MI300X now also excludes
chi-mi300x-121(missing Enroot/RAID provisioning), alongside the existing bad-node list. Config comments andperf-changelog.yamldocument the image, KV, and node changes forminimaxm3-fp8-mi300x-vllm.Reviewed by Cursor Bugbot for commit 771e633. Bugbot is set up for automated code reviews on this repo. Configure here.