Skip to content

[NVIDIA][GB300] update DSR1 FP8 GB300 TRTLLM image to latest#1767

Merged
cquil11 merged 11 commits into
mainfrom
update/dsr1-gb300-mtp-fp8
Jun 17, 2026
Merged

[NVIDIA][GB300] update DSR1 FP8 GB300 TRTLLM image to latest#1767
cquil11 merged 11 commits into
mainfrom
update/dsr1-gb300-mtp-fp8

Conversation

@xinli-sw

@xinli-sw xinli-sw commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

The release of nvcr.io/nvidia/ai-dynamo/tensorrtllm-runtime:1.3.0-dev.1-cuda13 contains a fix for NVIDIA/srt-slurm#51, where accuracy for one MTP config drops to 88% on GSM8k. While the point still passes evals on InferenceX, 95% is usually expected.

Dropped these configs

gen_worker_env_var: ' TRTLLM_FORCE_ALLTOALL_METHOD=NVLinkTwoSided ENABLE_CONFIGURABLE_MOE=1
    TRTLLM_FORCE_COMM_METHOD=NVLINK_TWO_SIDED'

In the latest container, NVLinkOneSided is the preferred backend and also the default, removing these to recover perf.


Note

Medium Risk
Changes published inference benchmark image and hardware runner for a flagship multinode TRT config, which directly affects accuracy and throughput numbers but does not alter application runtime code paths.

Overview
Updates dsr1-fp8-gb300-dynamo-trt to use tensorrtllm-runtime:1.3.0-dev.1-cuda13 (from 0.8.1.post2) and switches the runner from gb300 to gb300-nv, aligning the GB300 DeepSeek-R1 FP8 Dynamo/TRT benchmark with the latest container that fixes GSM8K accuracy and MTP concurrency issues.

Documents the change in perf-changelog.yaml: restored ~95% GSM8K accuracy (vs 88% on one point), resolution of numeric issues affecting some MTP points, and note that DSR1 TRTLLM FP8 configs should use the new image.

Reviewed by Cursor Bugbot for commit 4b8d282. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers.

If additional help is needed, PR authors can reach out to core maintainers over Slack.

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@xinli-sw xinli-sw changed the title [NVIDIA][GB300] update DSR1 FP8 GB300 TRTLLM image to latest [DNM][NVIDIA][GB300] update DSR1 FP8 GB300 TRTLLM image to latest Jun 15, 2026
@xinli-sw

Copy link
Copy Markdown
Collaborator Author

might need to do a quick update to 1k1k config , please do not enable sweep yet

@xinli-sw xinli-sw changed the title [DNM][NVIDIA][GB300] update DSR1 FP8 GB300 TRTLLM image to latest [NVIDIA][GB300] update DSR1 FP8 GB300 TRTLLM image to latest Jun 16, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9031353. Configure here.

Comment thread perf-changelog.yaml Outdated
@xinli-sw xinli-sw force-pushed the update/dsr1-gb300-mtp-fp8 branch from 68615eb to 3a9d26c Compare June 16, 2026 02:37
@github-actions

Copy link
Copy Markdown
Contributor

2 similar comments
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

Updated description for gsm8k accuracy fix to include config updates.
@github-actions

Copy link
Copy Markdown
Contributor

@functionstackx functionstackx left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm besides more detailed perfchange plz, explaining the onesidealltoall error vs twosidealltoall

Comment thread perf-changelog.yaml

- config-keys:
- dsr1-fp8-gb300-dynamo-trt
description:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xinli-sw can u add an new more of an description of what was broken and what was the fix?

Updated description for gsm8k accuracy fix and config updates.
@xinli-sw

Copy link
Copy Markdown
Collaborator Author

@functionstackx done

@cquil11

cquil11 commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

/reuse-sweep-run

@cquil11 cquil11 merged commit 7b9843d into main Jun 17, 2026
26 checks passed
@cquil11 cquil11 deleted the update/dsr1-gb300-mtp-fp8 branch June 17, 2026 14:23
@cquil11 cquil11 restored the update/dsr1-gb300-mtp-fp8 branch June 17, 2026 22:37
cquil11 added a commit that referenced this pull request Jun 17, 2026
Add a CPU-only artifact recovery path for PR #1767 using successful source run 27595478969.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants