[codex] Remove MI325X runner workarounds#1747
Merged
Merged
Conversation
Contributor
|
Claude finished @cquil11's task in 47s —— View job PR Review: Remove MI325X runner workarounds
LGTM — no blocking issues found. This is a clean removal of two workarounds that are no longer needed:
The resulting script is simpler and the changes are straightforward with no functional risk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chi-mi325x-pod1-121.ord.vultr.cpe.ice.amd.com.Note
Low Risk
Launcher-only script changes with no auth or data handling; main risk is jobs landing on a previously excluded node if the enroot/NFS issue regresses.
Overview
Removes temporary mitigations from
runners/launch_mi325x-amds.shnow that the underlying issues are addressed.Slurm scheduling:
sallocno longer passes--excludeforchi-mi325x-pod1-121, so that node can receive jobs again.Cleanup: Deletes
cleanup_stale_benchmark_logsand all invocations (startup and onEXIT), including thebenchmark_logsremoval underGITHUB_WORKSPACE. The exit trap only cancels the job and preserves the exit code.Reviewed by Cursor Bugbot for commit 0f0d7cb. Bugbot is set up for automated code reviews on this repo. Configure here.