-
Notifications
You must be signed in to change notification settings - Fork 210
[Klaud Cold] KLAUD_DEBUG: B300 is sm_103 (not sm_120) + cross-link sglang#25563 #1479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Pre-existing stale reference missed by this PR's cleanup pass:
.claude/commands/klaud-pr-status-html.md:171still contains a dashboard Reason-cell example keyed to PR #1422 reading "Upstream sglang v0.5.12flash_attnSM-arch regression on B300 (sm_120)." The PR description explicitly identifies "dashboard Reason cells" as one of the propagation targets for the bad sm_120 assumption — this template, which agents copy into/tmp/klaud_pr_diag.jsoneach/klaud-pr-status-htmlinvocation, was missed. Suggest updating it tosm_103in the same PR so the correction is not re-seeded on every run.Extended reasoning...
What the bug is
The PR corrects KLAUD_DEBUG.md §4 so that B300 (Blackwell Ultra) is described as
sm_103(compute capability 10.3) rather than the consumer-Blackwellsm_120. The PR description states explicitly that this bad assumption "had propagated through agent diagnoses, through several dashboardReasoncells, and into the upstream issue body" and that those have been corrected. However, one such propagated dashboard Reason cell — directly keyed to the same PR #1422 fixed in §4c — was not updated.Where it lives
.claude/commands/klaud-pr-status-html.md:171contains the example JSON template that agents copy verbatim into/tmp/klaud_pr_diag.jsonwhen generating dashboard HTML (per the surrounding instructions on lines 161–176). That template's Reason cell for PR #1422 still reads:A repo-wide grep for
sm_120returns exactly two hits: the corrective line in KLAUD_DEBUG.md:69 (introduced by this PR, and which deliberately disambiguatessm_120as consumer Blackwell) and this stale line in the slash-command template.Why this matters for this PR specifically
The PR is explicitly doc-only and scoped to scrubbing the bad sm_120 → B300 association from agent-facing materials. The template at
klaud-pr-status-html.md:171is exactly the class of artifact the PR description calls out ("dashboard Reason cells"). Because the template is the seed agents copy when generating fresh status JSON, leaving it assm_120causes each future/klaud-pr-status-htmlrun to re-inject the wrong arch string into newly produced dashboards — defeating the purpose of §4c's correction.Step-by-step propagation proof
/klaud-pr-status-html..claude/commands/klaud-pr-status-html.md(lines 161–176), the agent copies the example JSON block — including the Reason for PR 1422 — into/tmp/klaud_pr_diag.jsonas its starting scaffold.sm_120string.sm_120attributed to B300, and re-seeds the same wrong assumption that this PR is specifically trying to eradicate.Impact
Doc/template only — no runtime effect — but it directly undercuts the stated cleanup goal of the PR and will silently reintroduce the wrong arch on each dashboard regeneration until corrected.
Fix
Single-line edit in
.claude/commands/klaud-pr-status-html.md:171: change(<code>sm_120</code>)to(<code>sm_103</code>)so the template matches the corrected KLAUD_DEBUG.md §4c. Severity is nit since it is a doc-template fix, but it is in scope for this PR (which is explicitly a doc-only sm_120 → sm_103 cleanup pass).