Skip to content

Update gptoss-fp4-h100-vllm vLLM image to v0.20.2 #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Oseltamivir merged 2 commits into from
May 13, 2026
Merged

Update gptoss-fp4-h100-vllm vLLM image to v0.20.2 #1334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68c6c78
$Update gptoss-fp4-h100-vllm vLLM image to v0.20.2\n\nRef #1154\n\nCo…
github-actions[bot] May 12, 2026
d943e10
Merge branch 'main' into claude/issue-1154-gptoss-fp4-h100-vllm
Oseltamivir May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/configs/nvidia-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4102,7 +4102,7 @@ minimaxm2.5-fp4-b300-vllm:
- { tp: 8, conc-start: 4, conc-end: 4 }

gptoss-fp4-h100-vllm:
image: vllm/vllm-openai:v0.18.0
image: vllm/vllm-openai:v0.20.2
model: openai/gpt-oss-120b
model-prefix: gptoss
runner: h100
Expand Down
6 changes: 6 additions & 0 deletions perf-changelog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2343,3 +2343,9 @@
description:
- "Add Qwen3.5-397B-A17B FP8 MI355X ATOM benchmark configs with and without MTP"
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1310

- config-keys:
- gptoss-fp4-h100-vllm
description:
- "Update vLLM image from v0.18.0 to v0.20.2"
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX

@claude claude Bot May 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 The new perf-changelog entry at line 2351 has pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX — the literal XXX placeholder was never substituted with the actual PR number. Every other entry in this file uses a real numeric PR id (e.g. 1304, 1305, 1308, 1310), so this breaks the changelog → PR back-reference. Replace pull/XXX with pull/1334.

Extended reasoning...

What the bug is

The diff adds a new entry to perf-changelog.yaml (lines 2347–2351) documenting the vLLM image bump for gptoss-fp4-h100-vllm. The final line of that entry is:

pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX

The XXX is a copy-paste/template placeholder that the author forgot to replace with the real PR number before opening/merging. PR metadata identifies this PR as #1334, so the link should be .../pull/1334.

Why the existing entries make this an obvious deviation

Every adjacent entry in perf-changelog.yaml uses a concrete numeric PR id — the immediately preceding entry ends with .../pull/1310, and earlier entries reference 1304, 1305, 1308, etc. There is no convention in the file of leaving XXX as a placeholder; the schema expects a real PR number.

Impact

The pr-link is the only structured back-reference from a changelog entry to the PR that introduced the change. With XXX in place:

  • Following the link in a browser yields a GitHub 404, breaking the traceability hook entirely.
  • Any tooling that parses perf-changelog.yaml to surface 'what PR introduced this perf delta?' will return a broken/invalid URL for this entry.
  • The asymmetry with all other entries makes the changelog inconsistent and harder to audit.

This does not affect runtime behavior or benchmark execution, which is why severity is nit — but it is trivially correctable and should be fixed before merge.

Step-by-step proof

  1. Open perf-changelog.yaml at line 2351 in this PR.
  2. Observe: pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX.
  3. Compare with the preceding entry at line 2345: pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1310 — a real numeric PR id.
  4. Check this PR's number in metadata: PR Update gptoss-fp4-h100-vllm vLLM image to v0.20.2 #1334.
  5. Click the rendered link .../pull/XXX — GitHub returns 404 because XXX is not a valid pull-request id.
  6. Conclusion: line 2351 contains an un-substituted template placeholder that breaks the changelog→PR back-link.

How to fix

Replace the last line of the new entry with:

pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1334

No other changes are needed.

Loading