[py] add macOS specific keys to Key enum

[Delta456]

User description

🔗 Related Issues

#15945 but for Python

💥 What does this PR do?

This PR adds the missing macOS-specific symbolic keys OPTION and FN to the Keys enum in py/selenium/webdriver/common/keys. These keys are part of the macOS keyboard layout but were not previously represented in the enum.

🔧 Implementation Notes

Adds keys to the enum

💡 Additional Considerations

🔄 Types of changes

• New feature (non-breaking change which adds functionality and tests!)

---

PR Type

Enhancement

---

Description

• Add macOS-specific keys OPTIONS and FUNCTION to Python Keys enum

• Include extended macOS/ChromeDriver keys for right-side modifiers

• Add Unicode values for macOS keyboard layout compatibility

---

Changes walkthrough 📝

	Relevant files
Enhancement	keys.py Add macOS-specific keyboard keys to enum                                  py/selenium/webdriver/common/keys.py Add OPTIONS and FUNCTION keys for macOS symbolic keys Add right-side modifier keys (RIGHT_SHIFT, RIGHT_CONTROL, RIGHT_ALT, RIGHT_COMMAND) Include Unicode values and TODO comments for spec verification +10/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-code-review]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅ 15945 - PR Code Verified Compliant requirements: • Add macOS-specific keys (OPTION, FN) to Keys enum - implemented as OPTIONS and FUNCTION • Implement for Python binding (similar to PR #15910) Requires further human verification: • Provide macOS keyboard layout compatibility - needs testing on actual macOS systems

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Unicode Conflicts The OPTIONS and FUNCTION keys use Unicode values that conflict with RIGHT_SHIFT and RIGHT_CONTROL. OPTIONS uses \uE050 which is the same as RIGHT_SHIFT, and FUNCTION uses \uE051 which is the same as RIGHT_CONTROL. This will cause key conflicts. OPTIONS = "\uE050" # TODO: verify Unicode value with WebDriver spec FUNCTION = "\uE051" # TODO: symbolic only; confirm or remove in future Unverified Values The TODO comments indicate that Unicode values for OPTIONS and FUNCTION keys are unverified and may need to be confirmed or removed. This suggests the implementation is incomplete and may not work correctly. OPTIONS = "\uE050" # TODO: verify Unicode value with WebDriver spec FUNCTION = "\uE051" # TODO: symbolic only; confirm or remove in future

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	✅ Fix duplicate Unicode key mappings Suggestion Impact: The suggestion identified a critical issue with duplicate Unicode mappings. Instead of implementing the exact fix suggested, the commit resolved the conflict by completely removing the problematic OPTIONS and FUNCTION keys and reorganizing the code structure code diff: - # Extended macOS/ChromeDriver keys (based on observed Chrome usage) - RIGHT_SHIFT = "\ue050" - RIGHT_CONTROL = "\ue051" - RIGHT_ALT = "\ue052" - RIGHT_COMMAND = "\ue053" - - # Symbolic macOS keys not yet standardized - OPTIONS = "\uE050" # TODO: verify Unicode value with WebDriver spec - FUNCTION = "\uE051" # TODO: symbolic only; confirm or remove in future + # Extended macOS keys + LEFT_OPTION = LEFT_ALT + RIGHT_OPTION = RIGHT_ALT The OPTIONS and FUNCTION keys use Unicode values that conflict with the right-side modifier keys defined above. This creates duplicate Unicode mappings which could cause unexpected behavior when these keys are used. py/selenium/webdriver/common/keys.py [99-100] -OPTIONS = "\uE050" # TODO: verify Unicode value with WebDriver spec -FUNCTION = "\uE051" # TODO: symbolic only; confirm or remove in future +OPTIONS = "\uE054" # TODO: verify Unicode value with WebDriver spec +FUNCTION = "\uE055" # TODO: symbolic only; confirm or remove in future [Suggestion processed] Suggestion importance[1-10]: 9 __ Why: The suggestion correctly identifies that the Unicode values for OPTIONS (\uE050) and FUNCTION (\uE051) conflict with the newly added RIGHT_SHIFT (\ue050) and RIGHT_CONTROL (\ue051). This duplication could cause unexpected behavior and is a critical issue to fix. The proposed change resolves this conflict.	High
Update

[shbenzer]

Tested these unicode values locally (M2 mac) - no errors from the webdriver

[shbenzer]

Works locally

found some tweaks

[iampopovich]

@shbenzer
I think in the feature request #15945 we should check the compliance of the existing keys with the standard https://w3c.github.io/webdriver/#keyboard-actions as a whole. And not just add new key codes.

In Java binding there is a similar bug, which I mentioned earlier, with the discrepancy between the Options and Shift codes

[shbenzer]

@shbenzer I think in the feature request #15945 we should check the compliance of the existing keys with the standard https://w3c.github.io/webdriver/#keyboard-actions as a whole. And not just add new key codes.

In Java binding there is a similar bug, which I mentioned earlier, with the discrepancy between the Options and Shift codes

That's a good idea, but that doesn't preclude us from adding the new ones in this pr.

[Delta456]

@shbenzer feel free to incoporate these changes in this PR

[shbenzer]

LGTM