Repository navigation
Retry transient HTTP errors in blob IO - #336
Draft
higordearaujo-bsy wants to merge 3 commits into
Draft
higordearaujo-bsy wants to merge 3 commits into
higordearaujo-bsy wants to merge 3 commits into
Conversation
higordearaujo-bsy
force-pushed
the
main
branch
from
August 20, 2026 20:41
9ced9d5 to
ff5fbed
Compare
higordearaujo-bsy
force-pushed
the
main
branch
from
October 13, 2026 17:50
7f0863a to
7159030
Compare
higordearaujo-bsy
force-pushed
the
main
branch
from
October 13, 2026 19:16
7159030 to
035d936
Compare
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The intertwined retry, cancellation, concurrency, and request-replay behavior warrants final human review.
0 open findings
What changed in this PR
Adds shared transient retry infrastructure and applies it to blob HEAD, chunk, and commit operations.
Changes:
- Adds retry helpers, jitter backoff, Retry-After support, and transient exceptions.
- Introduces per-chunk retries, adaptive concurrency, and signed-URL-safe logging.
- Re-exports compute exceptions, updates versions, lock metadata, and tests.
| File | Description |
|---|---|
uv.lock |
Updates versions and lock metadata. |
packages/evo-sdk-common/pyproject.toml |
Bumps common to 0.6.0. |
packages/evo-sdk-common/src/evo/common/exceptions.py |
Adds shared transient HTTP definitions. |
packages/evo-sdk-common/src/evo/common/utils/retry.py |
Implements shared retry helpers and jitter. |
packages/evo-sdk-common/src/evo/common/utils/__init__.py |
Exports retry APIs. |
packages/evo-sdk-common/src/evo/common/io/exceptions.py |
Adds transient chunk errors. |
packages/evo-sdk-common/src/evo/common/io/_retry.py |
Defines the default blob retry policy. |
packages/evo-sdk-common/src/evo/common/io/_limiter.py |
Adds adaptive concurrency limiting. |
packages/evo-sdk-common/src/evo/common/io/chunked_io_manager.py |
Adds independent per-chunk retries. |
packages/evo-sdk-common/src/evo/common/io/http.py |
Retries HEAD requests and maps transient failures. |
packages/evo-sdk-common/src/evo/common/io/storage.py |
Retries block commits by default. |
packages/evo-sdk-common/src/evo/aio/_helpers.py |
Documents transport replay limitations. |
packages/evo-sdk-common/tests/common/test_exceptions.py |
Tests shared transient exceptions. |
packages/evo-sdk-common/tests/common/utils/test_retry.py |
Tests retry helpers and policies. |
packages/evo-sdk-common/tests/common/io/test_limiter.py |
Tests adaptive limiting. |
packages/evo-sdk-common/tests/common/io/test_chunked_io_manager.py |
Tests chunk retry behavior. |
packages/evo-sdk-common/tests/common/io/test_http.py |
Tests HTTP retries and redaction. |
packages/evo-sdk-common/tests/common/io/test_storage.py |
Tests block and commit retries. |
packages/evo-compute/pyproject.toml |
Bumps compute and common dependency versions. |
packages/evo-compute/src/evo/compute/exceptions.py |
Re-exports common transient definitions. |
packages/evo-compute/tests/test_client.py |
Verifies exception re-exports. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Classify transient HTTP statuses and transport failures as recoverable blob errors, preserving existing messages and using the current chunk and commit retry loops. Add regression coverage for default retries, identical commit payloads, exception chains, and permanent failures. Common suite: 595 passed, 37 skipped, one existing collection warning. Compute suite: 499 passed. Ruff check/format and uv lock --check passed.
Release the minimum transient blob retry fix and regenerate uv.lock. Retain uv-generated normalization of existing dependency markers and workspace metadata; no third-party package versions change. Common suite: 595 passed, 37 skipped, one existing collection warning. Compute suite: 499 passed. Ruff check/format, uv lock --check, and the lock-source checker passed.
higordearaujo-bsy
force-pushed
the
main
branch
from
October 13, 2026 20:52
035d936 to
0d47974
Compare
Move TransientAPIError and the transient HTTP status set to common while preserving compute import identity. Add factory, status-set, and compatibility regression tests; release compute 0.0.6 requiring common >=0.5.29 and regenerate the lockfile. Common suite: 597 passed, 37 skipped, one existing collection warning. Compute suite: 500 passed. Ruff check/format, uv lock --check, and the lock-source checker passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fear not, dear reviewer, I come in peace! Although the diff is 1000+ lines, most of it is tests, comments and whitespace. The SDK itself has fewer than 300 lines of source code changed. I have also organized the initial push in three commits that can be reviewed one at a time.
Description
Blob chunk and commit requests now retry transient failures using the existing blob retry loops and default
Retry. This fixes uploads failing on a single503 Service Unavailablefrom Put Block List.Old behavior
ChunkedIOError, whoserecover()returnsFalse. Chunk and commit retry loops re-raised it immediately, even with a large caller-suppliedRetry.New behavior
TransportErrorare raised as the newTransientChunkedIOError(aChunkedIOErrorsubclass withstatus), whoserecover()returnsTrue. The existing loops retry it with the caller'sRetry, or the default (3 attempts, exponential backoff).ChunkedIOErrorwith the same message.Retry-Afterand HEAD-probe retries follow in a separate PR.API and compatibility
evo.common.exceptions.TRANSIENT_HTTP_STATUSESandevo.common.io.exceptions.TransientChunkedIOError. Callers catchingChunkedIOErrorkeep working.evo-sdk-common0.5.29.uv lockalso normalized existing dependency markers and workspace metadata. No third-party or other workspace package versions changed.Replay limits
Retries reuse block IDs and the commit payload. Safe replay assumes an unchanged source, the same upload destination after URL renewal, no competing writer, and storage that accepts same-ID block overwrites and repeated identical block-list commits. Retries don't guarantee exactly-once metadata, versions or events.
Checklist