Skip to content

chromium-nosync@138.0.7204.184-r1465706: Add discontinued notes, remove checkver#2474

Merged
z-Fng merged 3 commits into
ScoopInstaller:masterfrom
val1984:patch-2
Sep 21, 2025
Merged

chromium-nosync@138.0.7204.184-r1465706: Add discontinued notes, remove checkver#2474
z-Fng merged 3 commits into
ScoopInstaller:masterfrom
val1984:patch-2

Conversation

@val1984

@val1984 val1984 commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

chromium-nosync is no longer updated: Hibbiki/chromium-win64@09101f3
Last version is 138 where Chromium is now 140.

Closes #2473

Summary by CodeRabbit

  • Documentation
    • Added a deprecation notice informing users this build will no longer receive updates and suggesting alternative options and references.
  • Chores
    • Simplified update behavior by removing the explicit external version-check step; automatic updates remain in place without the separate check endpoint.

@github-actions

Copy link
Copy Markdown
Contributor

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

chromium-nosync

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@coderabbitai

coderabbitai Bot commented Sep 21, 2025

Copy link
Copy Markdown

Walkthrough

Updated the Scoop manifest bucket/chromium-nosync.json: added a top-level notes field stating the build is no longer provided and removed the checkver block; autoupdate entry remains unchanged.

Changes

Cohort / File(s) Summary of Changes
Manifest metadata update
bucket/chromium-nosync.json
Added top-level notes stating the build is no longer provided and suggesting alternatives; removed the checkver block; retained autoupdate as-is.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my ears at notes that say “no more,”
A carrot-colored sign points to another store.
The checkver burrow’s closed—no nightly hop—
Autoupdate still nibbles at the crop.
I thump, I bounce, I merge with glee.

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title ("chromium-nosync@138.0.7204.184-r1465706: Add discontinued notes, remove checkver") is concise, references the manifest and version, and accurately summarizes the primary change (adding discontinued notes and removing checkver) visible in the changeset. It is specific and readable for teammates scanning history.
Linked Issues Check ✅ Passed The changes directly address linked issue #2473 by adding a discontinued/notes field and removing the checkver lookup, which implements the issue's request to mark chromium-nosync as no longer updated and effectively deprecate the manifest; the code changes match the issue's coding-related objectives. The PR also includes the upstream commit reference cited in the issue and closes the issue as stated.
Out of Scope Changes Check ✅ Passed Only bucket/chromium-nosync.json was modified (notes added, checkver removed) and the changes are directly related to the stated objectives; there are no other file edits or unrelated changes in the provided summary. Therefore there are no detectable out-of-scope changes.
Description Check ✅ Passed The PR description states the package is no longer updated, links to the upstream commit, notes the last available version, includes "Closes #2473", and confirms the contributor read the Contributing Guide, which satisfies the repository template's critical requirements and provides the needed context. The only minor omission is the unchecked "Use conventional PR title" checklist item in the template, but the description is otherwise complete and actionable.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 21471a2 and 522d529.

📒 Files selected for processing (1)
  • bucket/chromium-nosync.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • bucket/chromium-nosync.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
bucket/chromium-nosync.json (2)

7-7: Polish the notes copy for clarity and tone.

Suggested wording is clearer and idiomatic English.

-    "notes": "This build is not provided anymore, you should look for alternatives like ungoogled-chromium or chromium",
+    "notes": "This build is no longer provided upstream. Consider alternatives such as 'ungoogled-chromium' or 'chromium'.",

36-46: Remove autoupdate block to match the EOL status (checkver already removed).

Keeping autoupdate after upstream ended will confuse maintainers and CI; the regex will never match a new nosync asset.

-    "persist": "User Data",
-    "autoupdate": {
-        "architecture": {
-            "64bit": {
-                "url": "https://github.com/Hibbiki/chromium-win64/releases/download/v$version/chrome.nosync.7z",
-                "hash": {
-                    "url": "https://github.com/Hibbiki/chromium-win64/releases/latest",
-                    "regex": "$sha1  ../out/x64/chrome.nosync.7z"
-                }
-            }
-        }
-    }
+    "persist": "User Data"

Also applies to: 35-35

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b1f1774 and 21471a2.

📒 Files selected for processing (1)
  • bucket/chromium-nosync.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (2)
bucket/chromium-nosync.json (2)

11-11: Prefer SHA256 over SHA1 for integrity.

Verification attempted in the sandbox: curl downloaded the 364 MB asset but sha256sum is not installed, so SHA256 could not be computed.
Action: compute the SHA256 of the archived installer and update bucket/chromium-nosync.json (line 11) to:
"hash": "sha256:"

Compute examples:

  • Linux/macOS: sha256sum chrome.nosync.7z | awk '{print $1}' or shasum -a 256 chrome.nosync.7z
  • Windows PowerShell: (Get-FileHash -Algorithm SHA256 -Path chrome.nosync.7z).Hash

3-3: Verify Hibbiki published chrome.nosync.7z for v138.0.7204.184-r1465706 or update the pin.

No evidence Hibbiki published a chrome.nosync.7z for v138 — their Releases show nosync assets only through the v133 range and GitHub Actions runs through v137 (June 2025); Chromium upstream is at 140+. File: bucket/chromium-nosync.json (line 3) currently pins "version": "138.0.7204.184-r1465706". If Hibbiki did not publish v138 nosync, change the pin to the last published nosync or add the correct source/commit.

@z-Fng

z-Fng commented Sep 21, 2025

Copy link
Copy Markdown
Member

Thanks! By the way, remember to follow the Contributing Guide to use conventional PR title next time.

Submit your pull request. Titles should follow these rules:
* If it's a new manifest, use <app name>: Add version <version>.
* If it's an update to an existing manifest, use <app name>@<version>: <small description>.
* If it's something related to maintenance, use (chore): <small description>.

@z-Fng z-Fng changed the title chromium-nosync is not updated anymore chromium-nosync@138.0.7204.184-r1465706: Add discontinued notes, remove checkver Sep 21, 2025
@z-Fng

z-Fng commented Sep 21, 2025

Copy link
Copy Markdown
Member

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

chromium-nosync

  • Lint
  • Description
  • License
  • Hashes

Check the full log for details.

@z-Fng z-Fng merged commit ca25ac0 into ScoopInstaller:master Sep 21, 2025
3 checks passed
@z-Fng

z-Fng commented Sep 21, 2025

Copy link
Copy Markdown
Member

Thanks!

@val1984

val1984 commented Sep 21, 2025

Copy link
Copy Markdown
Contributor Author

Thanks! By the way, remember to follow the Contributing Guide to use conventional PR title next time.

Submit your pull request. Titles should follow these rules:

  • If it's a new manifest, use <app name>: Add version <version>.
  • If it's an update to an existing manifest, use <app name>@<version>: <small description>.
  • If it's something related to maintenance, use (chore): <small description>.

Noted, thanks! So I should have chosen the third option, correct? Also, I'm not sure if the manifest should be moved to the deprecated folder?

@val1984 val1984 deleted the patch-2 branch September 21, 2025 20:18
@z-Fng

z-Fng commented Sep 21, 2025

Copy link
Copy Markdown
Member

So I should have chosen the third option, correct?

The second one, as we intended to update the manifest notes to inform users of this and stop running checkver for it.

The third option is more about CI/CD, workflows, linting, etc.

Also, I'm not sure if the manifest should be moved to the deprecated folder?

No. chromium-nosync is still available but just will no longer receive updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: chromium-nosync is no longer updated

2 participants