chromium-nosync@138.0.7204.184-r1465706: Add discontinued notes, remove checkver#2474
Conversation
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with chromium-nosync
|
WalkthroughUpdated the Scoop manifest Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
bucket/chromium-nosync.json (2)
7-7: Polish the notes copy for clarity and tone.Suggested wording is clearer and idiomatic English.
- "notes": "This build is not provided anymore, you should look for alternatives like ungoogled-chromium or chromium", + "notes": "This build is no longer provided upstream. Consider alternatives such as 'ungoogled-chromium' or 'chromium'.",
36-46: Remove autoupdate block to match the EOL status (checkver already removed).Keeping autoupdate after upstream ended will confuse maintainers and CI; the regex will never match a new nosync asset.
- "persist": "User Data", - "autoupdate": { - "architecture": { - "64bit": { - "url": "https://github.com/Hibbiki/chromium-win64/releases/download/v$version/chrome.nosync.7z", - "hash": { - "url": "https://github.com/Hibbiki/chromium-win64/releases/latest", - "regex": "$sha1 ../out/x64/chrome.nosync.7z" - } - } - } - } + "persist": "User Data"Also applies to: 35-35
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/chromium-nosync.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (2)
bucket/chromium-nosync.json (2)
11-11: Prefer SHA256 over SHA1 for integrity.Verification attempted in the sandbox: curl downloaded the 364 MB asset but sha256sum is not installed, so SHA256 could not be computed.
Action: compute the SHA256 of the archived installer and update bucket/chromium-nosync.json (line 11) to:
"hash": "sha256:"Compute examples:
- Linux/macOS: sha256sum chrome.nosync.7z | awk '{print $1}' or shasum -a 256 chrome.nosync.7z
- Windows PowerShell: (Get-FileHash -Algorithm SHA256 -Path chrome.nosync.7z).Hash
3-3: Verify Hibbiki published chrome.nosync.7z for v138.0.7204.184-r1465706 or update the pin.No evidence Hibbiki published a chrome.nosync.7z for v138 — their Releases show nosync assets only through the v133 range and GitHub Actions runs through v137 (June 2025); Chromium upstream is at 140+. File: bucket/chromium-nosync.json (line 3) currently pins "version": "138.0.7204.184-r1465706". If Hibbiki did not publish v138 nosync, change the pin to the last published nosync or add the correct source/commit.
|
Thanks! By the way, remember to follow the Contributing Guide to use conventional PR title next time.
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. chromium-nosync
|
|
Thanks! |
Noted, thanks! So I should have chosen the third option, correct? Also, I'm not sure if the manifest should be moved to the |
The second one, as we intended to update the manifest notes to inform users of this and stop running checkver for it. The third option is more about CI/CD, workflows, linting, etc.
No. chromium-nosync is still available but just will no longer receive updates. |
chromium-nosync is no longer updated: Hibbiki/chromium-win64@09101f3
Last version is 138 where Chromium is now 140.
Closes #2473
Summary by CodeRabbit