Repository navigation
fix(manifest): match historical versions exactly - #6831
Open
LUX-ETVERITAS wants to merge 1 commit into
Open
LUX-ETVERITAS wants to merge 1 commit into
LUX-ETVERITAS wants to merge 1 commit into
Conversation
LUX-ETVERITAS
added a commit
to LUX-ETVERITAS/Scoop
that referenced
this pull request
Nov 16, 2026
LUX-ETVERITAS
force-pushed
the
fix/6822-historical-manifest-version-prefix
branch
from
November 16, 2026 03:29
462182d to
36fa125
Compare
LUX-ETVERITAS
force-pushed
the
fix/6822-historical-manifest-version-prefix
branch
from
November 16, 2026 03:32
36fa125 to
0ef19d1
Compare
Author
|
Addressed both Greptile findings in
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6822.
scoop install <app>@<version>andscoop download <app>@<version>fail to load a historical manifest when the requested version is a prefix of a later release (for example5.20vs5.20.1). Scoop printsNo historical manifest foundand falls back to autoupdate.Root cause
Find-HistoricalManifestInGitbuilds a pickaxe pattern without a right boundary:so a request for
5.20also matches"version": "5.20.1". Combined with-n 1, the newest matching commit is the bump away from a later release, and only that commit and its parent are inspected.Fix
([^0-9A-Za-z._+-]|$). A lookahead would be cleaner, butgit log -Guses a POSIX regex, so(?![.\d])fails withinvalid regex.-n 1), then widen the window to 20, 100, and finally the full history only when the exact version is not in the current batch. The common case still stops after one commit; the-Sfallback uses the same batching.Testing
Invoke-Pester test/Scoop-Manifest.Tests.ps1: 34 passed, 0 failed (Pester 6.0.0).5.20,5.20.1, and5.20.2resolve;5.2and5.18return$null.Checklist
developbranch.

Confidence Score: 5/5
The PR appears safe to merge; both previous findings are addressed.Summary
Fixes historical version lookup so a request such as
5.20does not also match5.20.1.Reviews (3) · Last reviewed commit: "fix(manifest): match historical versions..." · Reviewed by Greptile