Skip to content

wcurl: Update manifest#6117

Open
sitiom wants to merge 1 commit into
ScoopInstaller:masterfrom
sitiom:wcurl
Open

wcurl: Update manifest#6117
sitiom wants to merge 1 commit into
ScoopInstaller:masterfrom
sitiom:wcurl

Conversation

@sitiom

@sitiom sitiom commented Aug 19, 2024

Copy link
Copy Markdown
Contributor
  • Fix homepage order

  • Point url to the wcurl script instead of the entire archive.

  • Move depends to suggest & remove busybox dependency (Scoop automatically creates a shim to bash)

  • I have read the Contributing Guide.

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

wcurl

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@sitiom sitiom left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: wcurl doesn't show output due to a bug with Scoop (ScoopInstaller/Scoop#6112)

@niheaven

Copy link
Copy Markdown
Member

Issue: wcurl doesn't show output due to a bug with Scoop (ScoopInstaller/Scoop#6112)

That's why the origin manifest use an explicit sh in shim creation. And why install such a big git app just for a sh shell?

BTW, curl and sh is depends, not suggests for this script.

@sitiom

sitiom commented Aug 19, 2024

Copy link
Copy Markdown
Contributor Author

I'm trying to copy the neofetch manifest here. git is just a suggestion, the machine may already have bash installed (WSL) which I assume the shim already tries to find first.

BTW, curl and sh is depends, not suggests for this script.

curl is already built-in to Windows 10. Most "dependencies" in these buckets use suggest instead of depends to account for dependencies installed outside Scoop, don't they?

@niheaven

Copy link
Copy Markdown
Member

WSL's bash is very slow as I tried... So when I modify the manifest, I just keep sh and add busybox as depends.

curl is bundled since Windows 10 version 17063, but as scoop's min system requirement is Windows 7, leave it depends now.

@niheaven

Copy link
Copy Markdown
Member

Most "dependencies" in these buckets use suggest instead of depends to account for dependencies installed outside Scoop, don't they?

The additional feature depends is moved to suggests, but functional depends (curl for wcurl) is still depends, e.g., r for rstudio.

@sitiom

sitiom commented Aug 19, 2024

Copy link
Copy Markdown
Contributor Author

The additional feature depends is moved to suggests, but functional depends (curl for wcurl) is still depends, e.g., r for rstudio.

vcredist as a functional dependency is listed as suggest though 🤔

@sitiom

sitiom commented Aug 19, 2024

Copy link
Copy Markdown
Contributor Author

Issue: wcurl doesn't show output due to a bug with Scoop (ScoopInstaller/Scoop#6112)

@niheaven

Copy link
Copy Markdown
Member

vcredist as a functional dependency is listed as suggest though 🤔

It is common for many machines to have vcredist already installed, so vcredist is marked as suggests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants