fnm@1.38.1: Remove leftovers when uninstall --purge, set FNM_DIR, persist some data

[o-l-a-v]

Changes

• Purge will remove more leftovers of fnm.
  • Directories.
    • %LOCALAPPDATA%\fnm_multishells.
    • %APPDATA%\fnm.
  • Environment variables starting with FNM_.
• Will set environment variable FNM_DIR to Scoop $dir.
• Persist $dir\aliases and $dir\node-versions because of FNM_DIR.

More about purge of directories

fnm leaves behind two directories when uninstalled:

• %LOCALAPPDATA%\fnm_multishells
• %APPDATA%\fnm

This PR adds the ability to have them nuked when uninstall --purge.

Note: For some reason [System.IO.Directory]::Delete() failed to delete one of the directories with an error about access denied, but Remove-Item -Recurse worked. So I'm using Remove-Item -Recurse.

Contributing guidelines

• I have read the Contributing Guide.

[github-actions]

All changes look good.

Wait for review from human collaborators.

fnm

• Description
• License
• Hashes
• Checkver
• Autoupdate

[o-l-a-v]

/verify

[github-actions]

All changes look good.

Wait for review from human collaborators.

fnm

• Description
• License
• Hashes
• Checkver
• Autoupdate

[o-l-a-v]

/verify

[github-actions]

All changes look good.

Wait for review from human collaborators.

fnm

• Description
• License
• Hashes
• Checkver
• Autoupdate

[Lutra-Fs]

I guess we should set FNM_DIR up as well. See https://github.com/Schniz/fnm/blob/1ebc90decf58c2176dcbd4f8ac00ecb3adb1de12/docs/commands.md?plain=1#L33
and possibly add related persist option. It will affect %APPDATA%\fnm but we still need to handle %LOCALAPPDATA%\fnm_multishells

[o-l-a-v]

I (think I) added your suggestions @Lutra-Fs.

• Setting env variable FNM_DIR
• Persist aliases and node-versions directories
• Purge will remove any FNM_* environment variables

What you think? 😊

[o-l-a-v]

/verify

[github-actions]

All changes look good.

Wait for review from human collaborators.

fnm

• Description
• License
• Hashes
• Checkver
• Autoupdate

[Lutra-Fs]

I'll spin up a VM to install the updated manifest, try a couple of small projects, and then uninstall. If everything looks good, I'll go ahead and merge. One question: since the manifest uses env_set, do we also need to explicitly unset those variables in the post_uninstall script, or does Scoop handle cleanup automatically? I'm checking the source now to confirm.

[Lutra-Fs]

Can you kindly add a note to tell the user that the new config location will be under our directory? See #6462 (comment) for an example.

[o-l-a-v]

/verify

[github-actions]

All changes look good.

Wait for review from human collaborators.

fnm

• Description
• License
• Hashes
• Checkver
• Autoupdate

[o-l-a-v]

One potential problem is that FNM_DIR is not set in current session / process after scoop install fnm. Related:

• [Feature] env_set should set environment variable in process scope too Scoop#6440

I'll add info on that too.

[o-l-a-v]

Worked around it by setting $env:FNM_HOME in post_install.

[o-l-a-v]

/verify

[github-actions]

All changes look good.

Wait for review from human collaborators.

fnm

• Description
• License
• Hashes
• Checkver
• Autoupdate

[o-l-a-v]

/verify

[github-actions]

All changes look good.

Wait for review from human collaborators.

fnm

• Description
• License
• Hashes
• Checkver
• Autoupdate

[Lutra-Fs]

NVM, just noticed that you have fixed it. Reviewing the wrong version of the code 😢