kelivo: Update to version 1.1.15, fix checkver#17901
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR updates the kelivo Scoop manifest: it bumps the version to 1.1.15 and replaces the Windows 64‑bit download URL and SHA-256 hash; it also updates checkver to use jsonpath for extracting asset URLs and adjusts the regex to capture version and build from percent‑encoded Windows asset filenames for autoupdate. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f393a51 to
4f890c0
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/kelivo.json (1)
19-21: Please run local manifest verification before merge.Use:
scoop config debug truescoop config gh_token <your-github-token>(optional, read-only).\bin\checkver.ps1 -App kelivo -f.\bin\formatjson.ps1 -App kelivoscoop install bucket\kelivo.json -a 64bitAs per coding guidelines: "Provide clear instructions for testing the manifest locally before submission."
Also applies to: 26-26
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/kelivo.json` around lines 19 - 21, Run the local manifest verification steps for bucket/kelivo.json before merging: enable scoop debug and (optionally) set gh_token, run the checkver and formatjson scripts for App "kelivo", and attempt to install the manifest locally to validate 64-bit assets; while doing this confirm the "url" and "jsonpath" resolve the latest release assets and that the "regex" (Kelivo_windows_(?<version>[\d.]+)%2B(?<build>\d+)\.zip) matches the actual browser_download_url returned — if it fails, update the regex or jsonpath in kelivo.json and re-run the verification commands until the manifest installs cleanly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/kelivo.json`:
- Around line 19-21: Run the local manifest verification steps for
bucket/kelivo.json before merging: enable scoop debug and (optionally) set
gh_token, run the checkver and formatjson scripts for App "kelivo", and attempt
to install the manifest locally to validate 64-bit assets; while doing this
confirm the "url" and "jsonpath" resolve the latest release assets and that the
"regex" (Kelivo_windows_(?<version>[\d.]+)%2B(?<build>\d+)\.zip) matches the
actual browser_download_url returned — if it fails, update the regex or jsonpath
in kelivo.json and re-run the verification commands until the manifest installs
cleanly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b9697a8a-145f-41c3-b600-916edba92b73
📒 Files selected for processing (1)
bucket/kelivo.json
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/kelivo.json (1)
19-21: Local manifest validation steps before mergePlease run the standard Scoop checks for
kelivo:scoop config debug true scoop config gh_token <your-github-token> # optional, read-only .\bin\checkver.ps1 -App kelivo -f .\bin\formatjson.ps1 -App kelivo scoop install .\bucket\kelivo.json -a 64bitIf anything is unclear, refer to:
- Contribution Guide: https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
- Wiki: https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/kelivo.json` around lines 19 - 21, The manifest bucket/kelivo.json needs local validation using Scoop's standard checks before merging; run the listed commands (scoop config debug true, optional gh_token, .\bin\checkver.ps1 -App kelivo -f, .\bin\formatjson.ps1 -App kelivo, and scoop install .\bucket\kelivo.json -a 64bit) and fix any issues the tools report (incorrect release URL, jsonpath, or the regex "Kelivo_windows_(?<version>[\d.]+)%2B(?<build>\d+)\.zip")—ensure the url, jsonpath, and regex correctly match the GitHub latest release assets and reformat the JSON with formatjson.ps1 before pushing.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/kelivo.json`:
- Around line 19-21: The manifest bucket/kelivo.json needs local validation
using Scoop's standard checks before merging; run the listed commands (scoop
config debug true, optional gh_token, .\bin\checkver.ps1 -App kelivo -f,
.\bin\formatjson.ps1 -App kelivo, and scoop install .\bucket\kelivo.json -a
64bit) and fix any issues the tools report (incorrect release URL, jsonpath, or
the regex "Kelivo_windows_(?<version>[\d.]+)%2B(?<build>\d+)\.zip")—ensure the
url, jsonpath, and regex correctly match the GitHub latest release assets and
reformat the JSON with formatjson.ps1 before pushing.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6ed3bd90-6d61-4af9-80c3-e7b32abc10b5
📒 Files selected for processing (1)
bucket/kelivo.json
|
/verify |
|
All changes look good. Wait for review from human collaborators. kelivo
|
Closes #17900
<manifest-name[@version]|chore>: <general summary of the pull request>