losslesscut: Fix file associations & general manifest updates#17889
losslesscut: Fix file associations & general manifest updates#17889NECOtype wants to merge 4 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR refactors LosslessCut's Windows file association setup by replacing the old Applications\LosslessCut.exe registry scheme with a new LosslessCut-based registration structure. The install-associations.reg and uninstall-associations.reg registry scripts are updated to define and remove the new registry keys. The Scoop manifest's PowerShell post_install logic is reworked to load registry templates from the bucket scripts directory, perform placeholder substitution for the install path, and write the generated .reg files. The uninstaller.script is simplified, checkver is changed to an explicit GitHub URL object, and the homepage metadata is updated. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/verify |
|
All changes look good. Wait for review from human collaborators. losslesscut
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/losslesscut.json (1)
16-45: Please run the manifest validation flow locally before merge.Recommended commands for this manifest (
losslesscut):scoop config debug true scoop config gh_token <your-github-token> # read-only token .\bin\checkver.ps1 -App losslesscut -f .\bin\formatjson.ps1 -App losslesscut scoop install bucket\losslesscut.json -a 64bitReferences:
- Contribution Guide: https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
- Wiki: https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
As per coding guidelines: “Provide clear instructions for testing the manifest locally before submission” and include the official contribution guide/wiki links.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/losslesscut.json` around lines 16 - 45, The manifest for losslesscut (bucket/losslesscut.json) must be validated and tested locally before merging: run the checkver and format scripts and install the manifest in 64-bit mode to ensure the post_install script, checkver (github), and autoupdate URL work correctly—specifically run the equivalent of .\bin\checkver.ps1 -App losslesscut -f, .\bin\formatjson.ps1 -App losslesscut, and attempt scoop install of the manifest (64bit) to exercise post_install reg file generation and the uninstaller script; update the PR with confirmation that these commands passed and include the Contribution Guide and Wiki links per guidelines.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/losslesscut/install-associations.reg`:
- Line 4: The InstallLocation registry entry currently writes literal embedded
quotes (the line containing "InstallLocation"="\"$losslesscut\"" ), causing the
value to include double-quote characters; change that entry so it writes the raw
$losslesscut path without surrounding/escaped quotes, i.e. remove the embedded
escaped quotes in the InstallLocation value assignment so the registry stores
the plain path.
---
Nitpick comments:
In `@bucket/losslesscut.json`:
- Around line 16-45: The manifest for losslesscut (bucket/losslesscut.json) must
be validated and tested locally before merging: run the checkver and format
scripts and install the manifest in 64-bit mode to ensure the post_install
script, checkver (github), and autoupdate URL work correctly—specifically run
the equivalent of .\bin\checkver.ps1 -App losslesscut -f, .\bin\formatjson.ps1
-App losslesscut, and attempt scoop install of the manifest (64bit) to exercise
post_install reg file generation and the uninstaller script; update the PR with
confirmation that these commands passed and include the Contribution Guide and
Wiki links per guidelines.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 29c79e48-6618-42fd-80ea-5cddc166b684
📒 Files selected for processing (3)
bucket/losslesscut.jsonscripts/losslesscut/install-associations.regscripts/losslesscut/uninstall-associations.reg
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
/verify |
|
All changes look good. Wait for review from human collaborators. losslesscut
|
Closes #16723
The original
.regfiles werent working anymore.This PR
.regfilespost_installanduninstallerscriptsnotefor correct way of importing.regfileshomepageurl andcheckverforgithubpost_installbeforebin<manifest-name[@version]|chore>: <general summary of the pull request>