Skip to content

nping: add version 0.6.0#17015

Closed
xd-mau5 wants to merge 1 commit into
ScoopInstaller:masterfrom
xd-mau5:nping
Closed

nping: add version 0.6.0#17015
xd-mau5 wants to merge 1 commit into
ScoopInstaller:masterfrom
xd-mau5:nping

Conversation

@xd-mau5

@xd-mau5 xd-mau5 commented Jan 14, 2026

Copy link
Copy Markdown
Contributor

Closes #17013

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Added distribution manifest for Nping Windows 64-bit package, including version metadata, download configuration, integrity verification, and automated update support for seamless package distribution and maintenance.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Jan 14, 2026

Copy link
Copy Markdown

Walkthrough

A new manifest file for Nping (a Rust-based ping tool) was added to the bucket, specifying version 0.6.0 with architecture-specific download details, checksums, and auto-update configuration for Windows 64-bit systems.

Changes

Cohort / File(s) Summary
Nping Manifest
bucket/nping.json
New package manifest (24 lines) containing metadata (version 0.6.0, description, homepage, license), 64-bit Windows download URL with SHA256 hash, binary executable name, checkver regex pattern, and autoupdate template

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A new ping tool hops into the bucket,
Nping in Rust, let's go and pluck it!
Hashes are verified, manifests are clean,
Concurrent pings and charts—a sight to be seen! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding a new manifest file for nping version 0.6.0 in the repository.
Description check ✅ Passed The description includes issue reference (#17013) and confirms compliance with PR requirements. However, it lacks detailed explanation of what was added and why.
Linked Issues check ✅ Passed The PR successfully addresses issue #17013 by adding the nping manifest with correct version 0.6.0, download URL, and all required metadata matching the package request criteria.
Out of Scope Changes check ✅ Passed All changes are directly scoped to implementing the nping package request; the single file addition contains only the requested manifest configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

nping

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@bucket/nping.json`:
- Line 3: The description string has a minor grammar issue: change "mean" to
"means" in the JSON "description" field so it reads "Nping means NB Ping, A Ping
Tool in Rust with Real-Time Data and Visualizations"; update the "description"
value in the nping.json object's "description" property accordingly.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 90923e0 and 88d81e7.

📒 Files selected for processing (1)
  • bucket/nping.json
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/debugviewpp.json:14-21
Timestamp: 2025-10-16T13:42:43.224Z
Learning: In the DebugViewPP project (CobaltFusion/DebugViewPP), the executable name changed from "DebugView++.exe" (in v1.8.0.103 and earlier) to "Debugviewpp.exe" (in v1.9.0.28 and later). The manifest bucket/debugviewpp.json correctly uses "Debugviewpp.exe" for current versions.
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
📚 Learning: 2025-10-16T13:42:43.224Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/debugviewpp.json:14-21
Timestamp: 2025-10-16T13:42:43.224Z
Learning: In the DebugViewPP project (CobaltFusion/DebugViewPP), the executable name changed from "DebugView++.exe" (in v1.8.0.103 and earlier) to "Debugviewpp.exe" (in v1.9.0.28 and later). The manifest bucket/debugviewpp.json correctly uses "Debugviewpp.exe" for current versions.

Applied to files:

  • bucket/nping.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (4)
bucket/nping.json (4)

12-12: Potential naming conflict with Nmap's nping utility.

Note that nping is also the name of a network packet generation tool bundled with Nmap. Users who have Nmap installed may experience PATH conflicts. This is an upstream naming decision, but worth being aware of.


13-16: LGTM!

The checkver configuration correctly uses the GitHub releases page with an appropriate regex pattern for semantic versioning tags.


17-23: LGTM!

The autoupdate configuration correctly mirrors the architecture section and uses proper version substitution in the URL template.


6-11: Hash verified as correct. No 32-bit build is available upstream.

The SHA256 hash 39fd2ace5365b6f087cb6ca60ffd60570b3d2ea07f85c1fac5404e9625f00bb9 matches the GitHub release digest. The upstream nping v0.6.0 release only provides x86_64 Windows builds; no 32-bit variant exists in the release assets, so the manifest correctly reflects the available architecture.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Comment thread bucket/nping.json
@z-Fng

z-Fng commented Jan 15, 2026

Copy link
Copy Markdown
Member

@z-Fng z-Fng closed this Jan 15, 2026
@SorYoshino

Copy link
Copy Markdown
Contributor

Starting from version 0.6.1, Nping has been officially renamed to NBping. However, the repository name remains Nping, and the author is currently considering whether to rename it to NBping as well. To avoid unnecessary maintenance in the future, this PR will be temporarily marked as a draft until the author's final decision is confirmed.

@z-Fng z-Fng added duplicate and removed not ready labels Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: nping

3 participants