icechat: Update to version 9.54, fix checkver & autoupdate#16717
Conversation
WalkthroughUpdated IceChat package manifest from version 9.53 to 9.54, changing from portable zip distribution to Inno Setup installer. License metadata expanded from string to structured object with URL. Checkver regex and autoupdate paths updated accordingly with new version suffix. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. icechat
|
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/icechat.json(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
📚 Learning: 2025-09-05T09:41:52.653Z
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
Applied to files:
bucket/icechat.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (3)
bucket/icechat.json (3)
5-10: License and metadata updates are appropriate.The license restructuring to include a reference URL improves transparency, and the URL/hash updates correctly reflect the shift to the Inno Setup installer distribution.
5-10: License and metadata updates are appropriate.The license restructuring to include a reference URL improves transparency, and the URL/hash updates correctly reflect the shift to the Inno Setup installer distribution.
20-21: Regex pattern correctly matches IceChat's GitHub release tags.The regex
"tag/([\\d.]+)(?=F)"correctly extracts the base version number from IceChat's release tags. IceChat's GitHub releases follow the format of numeric versions with an "F" suffix (e.g., "9.54F"), and the positive lookahead(?=F)ensures the pattern matches only full installer releases while capturing the version number without the suffix.
Summary
Updates
icechatto version 9.54 and transitions the manifest from the legacy portable ZIP package to the official Inno Setup installer.Related issues or pull requests
Changes
innosetup: trueto enable automatic extraction and installation9.54Frelease structurecheckverwith a refined regex that captures versions ending inFautoupdateURL to align with the installer-based release namingNotes
Testing
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.