Skip to content

icechat: Update to version 9.54, fix checkver & autoupdate#16717

Merged
z-Fng merged 1 commit into
ScoopInstaller:masterfrom
SorYoshino:icechat
Dec 4, 2025
Merged

icechat: Update to version 9.54, fix checkver & autoupdate#16717
z-Fng merged 1 commit into
ScoopInstaller:masterfrom
SorYoshino:icechat

Conversation

@SorYoshino

@SorYoshino SorYoshino commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

Summary

Updates icechat to version 9.54 and transitions the manifest from the legacy portable ZIP package to the official Inno Setup installer.

Related issues or pull requests

Changes

  • Update version to 9.54
  • Add innosetup: true to enable automatic extraction and installation
  • Update download URL to match the new 9.54F release structure
  • Update checkver with a refined regex that captures versions ending in F
  • Update autoupdate URL to align with the installer-based release naming

Notes

  • The software is no longer actively maintained, and the latest version (9.54) does not provide a portable edition.

Testing

┏[ D:\Software\Scoop\Local\apps\scoop\current\bin][ master ≡]
└─> .\checkver.ps1 -App icechat -Dir 'D:\Temporary\Software\Microsoft\Windows Sandbox\Repositories\Scoop\Buckets\Extras\bucket' -f
icechat: 9.54 (scoop version is 9.54)
Forcing autoupdate!
Autoupdating icechat
DEBUG[1764843866] [$updatedProperties] = [url hash] -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:491:5
DEBUG[1764843866] $substitutions (hashtable) -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:221:5
DEBUG[1764843866] $substitutions.$baseurl                       https://github.com/icechat/IceChat/releases/download/9.54F
DEBUG[1764843866] $substitutions.$match1                        9.54
DEBUG[1764843866] $substitutions.$underscoreVersion             9_54
DEBUG[1764843866] $substitutions.$basenameNoExt                 icechat-setup
DEBUG[1764843866] $substitutions.$urlNoExt                      https://github.com/icechat/IceChat/releases/download/9.54F/icechat-setup
DEBUG[1764843866] $substitutions.$basename                      icechat-setup.exe
DEBUG[1764843866] $substitutions.$matchHead                     9.54
DEBUG[1764843866] $substitutions.$preReleaseVersion             9.54
DEBUG[1764843866] $substitutions.$url                           https://github.com/icechat/IceChat/releases/download/9.54F/icechat-setup.exe
DEBUG[1764843866] $substitutions.$dashVersion                   9-54
DEBUG[1764843866] $substitutions.$dotVersion                    9.54
DEBUG[1764843866] $substitutions.$cleanVersion                  954
DEBUG[1764843866] $substitutions.$majorVersion                  9
DEBUG[1764843866] $substitutions.$buildVersion
DEBUG[1764843866] $substitutions.$matchTail
DEBUG[1764843866] $substitutions.$patchVersion
DEBUG[1764843866] $substitutions.$version                       9.54
DEBUG[1764843866] $substitutions.$minorVersion                  54
DEBUG[1764843866] $hashfile_url = $null -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:224:5
DEBUG[1764843866] $jsonpath = $..assets[?(@.browser_download_url == 'https://github.com/icechat/IceChat/releases/download/9.54F/icechat-setup.exe')].digest -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:132:5
Could not find hash in https://api.github.com/repos/icechat/IceChat/releases
Downloading icechat-setup.exe to compute hashes!
Loading icechat-setup.exe from cache
Computed hash: c3d31b77991a33c0d517a668646a4df43400b53565115e5728f930268f4f3dbc
Writing updated icechat manifest

┏[ D:\Software\Scoop\Local\apps\scoop\current\bin][ master ≡]
└─> scoop install Unofficial/icechat
Installing 'icechat' (9.54) [64bit] from 'Unofficial' bucket
Loading icechat-setup.exe from cache.
Checking hash of icechat-setup.exe ... ok.
Extracting icechat-setup.exe ... done.
Linking D:\Software\Scoop\Local\apps\icechat\current => D:\Software\Scoop\Local\apps\icechat\9.54
Creating shim for 'IceChat2009'.
Making D:\Software\Scoop\Local\shims\icechat2009.exe a GUI binary.
Creating shortcut for IceChat IRC Client (IceChat2009.exe)
'icechat' (9.54) was installed successfully!
  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Updates
    • Version upgraded to 9.54
    • Installation method switched to Inno Setup installer format
    • License information now includes direct link reference

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Dec 4, 2025

Copy link
Copy Markdown

Walkthrough

Updated IceChat package manifest from version 9.53 to 9.54, changing from portable zip distribution to Inno Setup installer. License metadata expanded from string to structured object with URL. Checkver regex and autoupdate paths updated accordingly with new version suffix.

Changes

Cohort / File(s) Summary
IceChat Package Manifest
bucket/icechat.json
Version bumped to 9.54; license converted from string to object format with identifier and GitHub URL; distribution artifact changed from portable zip to Inno Setup executable; hash updated; added innosetup: true flag; enhanced checkver with regex pattern to parse version with "F" suffix; autoupdate URL refactored to use new installer path and version variable format.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify new binary hash against official release
  • Confirm Inno Setup executable URL accessibility and correctness
  • Validate regex pattern tag/([\\d.]+)(?=F) matches intended version format
  • Ensure version variable syntax $versionF is compatible with autoupdate mechanism

Suggested labels

review-needed

Suggested reviewers

  • z-Fng

Poem

🐰 A nibble here, a version there,
From zip to setup, with utmost care,
The manifest hops to point-five-four,
With license links we did adore,
Now IceChat's ready, sleek and fair! ❄️

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The PR title accurately describes the main changes: version update to 9.54 and fixes to checkver and autoupdate configuration.
Description check ✅ Passed The PR description is comprehensive and includes all required sections: summary, related issues, changes, notes, testing results, and confirmation of contribution guidelines.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

icechat

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f433184 and 18b2e8f.

📒 Files selected for processing (1)
  • bucket/icechat.json (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
📚 Learning: 2025-09-05T09:41:52.653Z
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.

Applied to files:

  • bucket/icechat.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (3)
bucket/icechat.json (3)

5-10: License and metadata updates are appropriate.

The license restructuring to include a reference URL improves transparency, and the URL/hash updates correctly reflect the shift to the Inno Setup installer distribution.


5-10: License and metadata updates are appropriate.

The license restructuring to include a reference URL improves transparency, and the URL/hash updates correctly reflect the shift to the Inno Setup installer distribution.


20-21: Regex pattern correctly matches IceChat's GitHub release tags.

The regex "tag/([\\d.]+)(?=F)" correctly extracts the base version number from IceChat's release tags. IceChat's GitHub releases follow the format of numeric versions with an "F" suffix (e.g., "9.54F"), and the positive lookahead (?=F) ensures the pattern matches only full installer releases while capturing the version number without the suffix.

Comment thread bucket/icechat.json
Comment thread bucket/icechat.json

@z-Fng z-Fng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng merged commit 1aa6259 into ScoopInstaller:master Dec 4, 2025
4 checks passed
@SorYoshino SorYoshino deleted the icechat branch December 4, 2025 18:18
@coderabbitai coderabbitai Bot mentioned this pull request Mar 28, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants