php(-nts)-xdebug: Update to version 3.4.7-84, fix checkver & autoupdate#16638
Merged
Conversation
WalkthroughTwo Xdebug manifests (NTS and TS) update the version to 3.4.7-84, correct the license URL/identifier, refresh DLL URLs and SHA256 hashes, and replace simple checkver/autoupdate regexes with a PowerShell-based parser and $matchName-based download/hash lookup against the historical downloads page. Changes
Sequence Diagram(s)sequenceDiagram
participant S as Scoop checkver/autoupdate
participant H as xdebug.org/download/historical
participant PS as PowerShell parser (embedded)
participant A as URL template ($matchName)
participant D as Download (DLL)
participant HASH as Hash extraction (historical page regex)
S->>H: GET historical page
H-->>PS: page HTML
PS->>PS: parse entries -> produce "XdebugVersion-PHPVersion / FileName" ($matchName)
PS-->>S: return $matchName and version
S->>A: construct download URL using $matchName
A->>D: fetch DLL
S->>H: fetch historical page for hash lookup
H-->>HASH: run regex against basename
HASH-->>S: return SHA256
S->>D: verify SHA256
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All changes look good. Wait for review from human collaborators. php-nts-xdebug
php-xdebug
|
Contributor
Author
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. php-nts-xdebug
php-xdebug
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates both
php-xdebugandphp-nts-xdebugto version 3.4.7-84, corrects upstream asset naming changes, rebuilds thecheckver/autoupdatelogic to ensure reliable version detection and hashing, and improves the manifest metadata for accuracy and future maintainability.Related issues or pull requests
Changes
licensefieldcheckverusing a PowerShell script to:autoupdateto:$matchNamefor fully dynamic asset resolutionTesting
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.