Repository navigation
test(web): steady the video attachment and right panel Escape tests on Linux CI - #613
Merged
Merged
Conversation
"renders video attachments with the shared video player" points the video at a host that does not exist. On CI the browser's load error can arrive during the frame the test waits before reading the markup, and the player has already swapped in its unavailable state, so the <video> assertion fails. The test covers rendering, and a separate test covers the unavailable state, so stop video error events in their capture phase for this test only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
"uses a custom binding from a text field and closes on Escape" has failed on Linux CI repeatedly (twice in a row on #613): after Escape, focus stayed on <body> for the whole 5 s wait. Even with no running animations, Base UI defers close completion through its shared animation-frame scheduler, so focus restoration depended on frame timing in the CI iframe. Disable Base UI animations for this scenario through its documented BASE_UI_ANIMATIONS_DISABLED global, which unstubAllGlobals resets. Also establish real frame and input focus first, check that focus moved into the menu before Escape, then assert the menu unmounted and focus is back on the trigger. Blocking the trigger's focus() still fails the test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two main browser tests fail on Linux CI and drop PRs from the merge queue. Neither failure is related to the PRs they drop.
MessagesTimeline"renders video attachments with the shared video player". The test points the video athttps://environment.test/api/assets/demo.mp4, a host that doesn't exist. On CI the browser's load error can arrive during the frame the test waits before reading the markup. By thenMediaVideoPlayerhas already swapped in "Video preview unavailable", so the<video>assertion fails.RightPanelTabs"uses a custom binding from a text field and closes on Escape". After Escape, focus stayed on<body>for the whole 5 s wait. This failed twice in a row on this PR's own CI and has dropped many queue entries recently. Even with no running animations, Base UI defers close completion through its shared animation-frame scheduler. That makes focus restoration depend on frame timing inside the CI iframe.Change
Both are test-only changes, and product code is unchanged.
errorlistener ondocumentstops error events whose target is a<video>. The listener is removed inonTestFinished. This test covers rendering, and the next test still covers the unavailable state. It sits inside the existing Scient-ownedSCIENT-FORKsection, and upstream T3 doesn't have it.SCIENT-FORKmarkers inside the upstream-owned test.BASE_UI_ANIMATIONS_DISABLEDglobal (declared in@base-ui/react/global.d.tsand read byuseAnimationsFinished). The file'sunstubAllGlobalsresets it.focus()still makes the test fail.Verification
RightPanelTabs.keyboard.browser.test.tsx: 10 of 10 full-file runs passed (90 tests), with no Reactact()warnings.vp fmtandvp linton both files: 0 errors.Documentation impact: None — test-only changes.
Model: Claude Opus 5.5 in Claude Code (Scient). The RightPanelTabs investigation and fix are by Codex
gpt-6.1-sol.🤖 Generated with Claude Code