Skip to content

compare clean path#447

Merged
iceljc merged 1 commit intoSciSharp:mainfrom
iceljc:main
May 1, 2026
Merged

compare clean path#447
iceljc merged 1 commit intoSciSharp:mainfrom
iceljc:main

Conversation

@iceljc
Copy link
Copy Markdown
Collaborator

@iceljc iceljc commented May 1, 2026

No description provided.

@iceljc iceljc merged commit d365c08 into SciSharp:main May 1, 2026
1 of 2 checks passed
@qodo-code-review
Copy link
Copy Markdown

Review Summary by Qodo

Normalize URL paths in menu link comparisons

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Normalize URL path comparisons using new getCleanPath helper
• Import and apply getCleanUrl utility for consistent path handling
• Update menu link matching logic to compare cleaned paths
• Simplify getPathUrl function to return pathname directly
Diagram
flowchart LR
  A["Menu Link Matching"] -->|Apply getCleanPath| B["Normalize URLs"]
  B -->|Compare cleaned paths| C["Consistent Results"]
  D["getCleanUrl utility"] -->|Extract clean path| B
Loading

Grey Divider

File Changes

1. src/lib/common/embedding/EmbeddingPage.svelte ✨ Enhancement +11/-6

Implement URL path normalization for menu matching

• Added import of getCleanUrl from common utilities
• Created new getCleanPath helper function that normalizes URLs by removing query parameters
• Updated menu item link comparisons to use getCleanPath for consistent matching across main menu
 and submenus
• Simplified getPathUrl function to return pathname directly without substring manipulation

src/lib/common/embedding/EmbeddingPage.svelte


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review Bot commented May 1, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant