compare clean path#447
Merged
iceljc merged 1 commit intoSciSharp:mainfrom May 1, 2026
Merged
Conversation
Review Summary by QodoNormalize URL paths in menu link comparisons
WalkthroughsDescription• Normalize URL path comparisons using new getCleanPath helper • Import and apply getCleanUrl utility for consistent path handling • Update menu link matching logic to compare cleaned paths • Simplify getPathUrl function to return pathname directly Diagramflowchart LR
A["Menu Link Matching"] -->|Apply getCleanPath| B["Normalize URLs"]
B -->|Compare cleaned paths| C["Consistent Results"]
D["getCleanUrl utility"] -->|Extract clean path| B
File Changes1. src/lib/common/embedding/EmbeddingPage.svelte
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.