adds vector syntax for ArrayPartitions and VectorOfArrays#546
adds vector syntax for ArrayPartitions and VectorOfArrays#546rokke-git wants to merge 3 commits intoSciML:masterfrom
ArrayPartitions and VectorOfArrays#546Conversation
810b005 to
ad0fd90
Compare
|
the typo I fixed shouldn't effect the test cases though, not sure why it was saying it was undefined in your CI? is there somewhere other than do we need to export edit: actually, some more thorough testing showed that the vcat had some unintuitive behavior and it also didn't always consistently use my definition (ie, some definitions from base are more specific and take priority), and the |
|
Docs and ocstrings? |
|
the only docs I saw was the readme, so I added an example there. the docs folder is kinda empty so I didn't know where you'd even want it there I hadn't thought about docstrings, can add some real quick |
|
I tried adding a recursive example of the func(u, p, t) = AP[u.x[1], AP[u.x[2].x[1], u.x[2].x[2]]]
ODEProblem(func, AP[ [1.,2.,3.], AP[[1. 2.;3. 4.], [4. 3.;2. 1.]] ], (0, 1)) |> solvewouldn't work? it's equivalent to the more verbose function func(u, p, t)
return ArrayPartition(
u.x[1],
ArrayPartition(
u.x[2].x[1],
u.x[2].x[2],
),
)
end
ODEProblem(
func,
ArrayPartition(
[1., 2., 3.],
ArrayPartition(
[1. 2.;3. 4.],
[4. 3.;2. 1.],
),
),
(0, 1),
) |> solve |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
tested everything in
./testlocally; theCUDAone failed onusing CUDA, and theutils_testhad some failing tests which aren't affected by this pr.I added a second commit showing all the things for
./test, if you don't want to use it there you can just cherrypick the first commitfixes #544