Repository navigation
.github/workflows: add defconfig build and PR comment workflows - #7604
Open
seokhun-eom24 wants to merge 9 commits into
Open
seokhun-eom24 wants to merge 9 commits into
seokhun-eom24 wants to merge 9 commits into
Conversation
Build configured defconfigs in parallel and retain build outputs as artifacts. Post the build summary to the pull request and update the existing comment on reruns. Co-authored-by: Codex Signed-off-by: seokhun-eom <seokhun.eom@samsung.com>
Fix inconsistent configs in qemu and rtl8721csm defconfigs. - Enable CONFIG_DEBUG_FULLOPT and disable CONFIG_DEBUG_NOOPT in the four remaining unoptimized configurations. - Enable CONFIG_STRESS_TOOL in rdp and tls_test. - Set CONFIG_WIFIMANAGER_TEST_TRIAL to 5 in rdp and tls_test. - Disable APP1_INFO and APP2_INFO in tc_16m because application binary separation is disabled. - Set GRPC_PTHREAD_SIZE to 16384 in tc_16m_grpc so gRPC thread creation compiles. - Disable CONFIG_TASH_REBOOT in smartfs, tc_1m and tc_16m_grpc. Co-authored-by: Codex Signed-off-by: seokhun-eom <seokhun.eom@samsung.com>
Taejun-Kwon
reviewed
Nov 10, 2026
| #ifdef CONFIG_BOARDCTL_RESET | ||
| boardctl(BOARDIOC_RESET, EXIT_SUCCESS); | ||
| #else | ||
| printf("CONFIG_BOARDCTL_RESET is not set. Fail to reset board.\n"); |
Contributor
There was a problem hiding this comment.
So, reboot is performed by reset, shouldn't it now show up in tash menu if CONFIG_BOARDCTL_RESET is not enabled?
Contributor
Author
There was a problem hiding this comment.
Yes, that is correct. CONFIG_TASH_REBOOT already depends on CONFIG_BOARDCTL_RESET.
This was a change made prior to modifying the config, but it was not reverted.
I resolved the issue by disabling CONFIG_TASH_REBOOT in some qemu defconfig, where CONFIG_BOARDCTL_RESET is currently disabled.
Thank you for finding this.
Print application heap statistics only when CONFIG_APP_BINARY_SEPARATION is enabled. Avoid compiling binary heap access when application binary separation is disabled. Co-authored-by: Codex Signed-off-by: seokhun-eom <seokhun.eom@samsung.com>
Remove an extra opening parenthesis from wm_sta_disconnected(). Fix the syntax error encountered when CONFIG_EXAMPLES_TAHI is enabled. Co-authored-by: Codex Signed-off-by: seokhun-eom <seokhun.eom@samsung.com>
Use the CMSIS-DSP and CMSIS-NN headers under external/include. Replace the removed amebad include paths so TensorFlow Lite Micro can find arm_nnfunctions.h. Co-authored-by: Codex Signed-off-by: seokhun-eom <seokhun.eom@samsung.com>
Remove -Werror so compiler warnings do not stop QEMU builds. Keep the existing warning checks enabled. Co-authored-by: Codex Signed-off-by: seokhun-eom <seokhun.eom@samsung.com>
Increase the flash-sram linker region to 128 MiB while retaining 64 KiB SRAM. Document the matching QEMU flash capacity required to run tc_64k. Co-authored-by: Codex Signed-off-by: seokhun-eom <seokhun.eom@samsung.com>
seokhun-eom24
force-pushed
the
261105-github-actions
branch
from
November 11, 2026 09:04
a3335d6 to
f59d5ff
Compare
Exclude these failing configurations from the automatically generated build matrix. Signed-off-by: seokhun-eom <seokhun.eom@samsung.com>
mbedTLS 3.4 builds fail because MBEDTLS_CERTS_C is unavailable and key parsing requires RNG arguments. Drop the obsolete feature check and export tls_handshake_server in the fallback. Seed CTR_DRBG before key parsing and pass its RNG callback and context. [Result] ``` TASH>>tls_seclink TASH>>-- [TLS SECLINK TEST] START -- Hello, TLS Server Test [SERVER] . Seeding the random number generator...[SERVER] ok [SERVER] . Loading the server cert. and key...[SERVER] ok [SERVER] . Bind on https://localhost:4433/ ...[SERVER] ok [SERVER] . Setting up the SSL data....[SERVER] ok [SERVER] . Waiting for a remote connection ...Hello, TLS Clinet Test [CLIENT] . Seeding the random number generator...[CLIENT] ok [CLIENT] . Loading the CA root certificate ...[CLIENT] ok (0 skipped) [CLIENT] . Connecting to tcp/127.0.0.1/4433...[SERVER] ok [SERVER] . Performing the SSL/TLS handshake...[CLIENT] ok [CLIENT] . Setting up the SSL/TLS structure...[CLIENT] ok [CLIENT] . Performing the SSL/TLS handshake...[SERVER] ok [SERVER] < Read from client: [CLIENT] ok [CLIENT] . Verifying peer X.509 certificate...[CLIENT] ok [CLIENT] > Start Packet Perfomance Test [28] [CLIENT] Try Write #1 [ 64 bytes ] --> [CLIENT] Try Write #1 Done <-- [CLIENT] Try Write #2 [ 128 bytes ] --> [CLIENT] Try Write #2 Done <-- [CLIENT] Try Write #3 [ 256 bytes ] --> [CLIENT] Try Write #3 Done <-- [CLIENT] Try Write #4 [ 512 bytes ] --> [CLIENT] Try Write #4 Done <-- [CLIENT] Try Write Samsung#5 [ 1024 bytes ] --> [CLIENT] Try Write Samsung#5 Done <-- [CLIENT] Try Write Samsung#6 [ 2048 bytes ] --> [CLIENT] Try Write Samsung#6 Done <-- [CLIENT] Try Write Samsung#7 [ 4096 bytes ] --> [CLIENT] Try Write Samsung#7 Done <-- [CLIENT] < Read from server: [SERVER] > Start Packet Perfomance Test [28] [SERVER] . Closing the connection...[SERVER] ok [CLIENT] 64 bytes read [CLIENT] 128 bytes read [CLIENT] 256 bytes read [CLIENT] 512 bytes read [CLIENT] 1024 bytes read [CLIENT] 2048 bytes read [CLIENT] 4096 bytes read [CLIENT] End : 0 -- [SERVER] End : 0 -- -- [TLS SECLINK TEST] Success -- ------------------------------------------------------------------------------------------- | 64 | 128 | 256 | 512 | 1024 | 2048 | 4096 | ------------------------------------------------------------------------------------------- Encrypt | 1020 | 1290 | 2190 | 3840 | 21870 | 26700 | 26040 | Decrypt | 990 | 1230 | 1950 | 3570 | 6720 | 12750 | 25170 | ------------------------------------------------------------------------------------------- -- [TLS SECLINK TEST] DONE -- ``` Co-authored-by: Codex Signed-off-by: seokhun-eom <seokhun.eom@samsung.com>
Contributor
Author
|
@hk-gwak Could you review some minor changes? |
hk-gwak
approved these changes
Nov 13, 2026
Collaborator
|
Hi, I have completed the review of wifi manager. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. .github/workflows: add defconfig build and PR comment workflows
Build configured defconfigs in parallel and retain build outputs as artifacts.
Post the build summary to the pull request and update the existing comment on reruns.
2. build/configs: Fix inconsistent configurations
Fix inconsistent configs in qemu and rtl8721csm defconfigs.
3. apps/system/utils: Guard application heap statistics
Print application heap statistics only when CONFIG_APP_BINARY_SEPARATION is enabled.
Avoid compiling binary heap access when application binary separation is disabled.
4. apps/examples/wifi_manager/tahi: Fix disconnect callback declaration
Remove an extra opening parenthesis from wm_sta_disconnected().
Fix the syntax error encountered when CONFIG_EXAMPLES_TAHI is enabled.
5. build/configs/rtl8721csm: Update CMSIS header paths
Use the CMSIS-DSP and CMSIS-NN headers under external/include.
Replace the removed amebad include paths so TensorFlow Lite Micro can find arm_nnfunctions.h.
6. build/configs/qemu: Remove -Werror from C compiler flags
Remove -Werror so compiler warnings do not stop QEMU builds.
Keep the existing warning checks enabled.
7. build/configs/qemu: Expand tc_64k flash to 128 MiB
Increase the flash-sram linker region to 128 MiB while retaining 64 KiB SRAM.
Document the matching QEMU flash capacity required to run tc_64k.
8. build/configs/qemu: Remove tc_1m and tc_16m_grpc defconfigs
Exclude these failing configurations from the automatically generated build matrix.
9. apps/examples/performance: Fix TLS server builds with mbedTLS 3.4
mbedTLS 3.4 builds fail because MBEDTLS_CERTS_C is unavailable and key parsing requires RNG arguments.
Drop the obsolete feature check and export tls_handshake_server in the fallback.
Seed CTR_DRBG before key parsing and pass its RNG callback and context.