Skip to content

Stop wallpaper polling after restoring defaults #349

Description

@Shreya-nipunge

Description

Restoring default settings changes the color mode from wallpaper-adaptive to manual, but the main-process wallpaper polling interval remains active.

As a result, Paraline continues querying the Windows wallpaper registry every five seconds when the Node.js polling fallback was previously running.

resetAllSettings() replaces the current settings with the defaults but does not call reconcileWallpaperPolling() afterward.

Steps to Reproduce

  1. Run Paraline without a connected audio helper so that the Node.js wallpaper polling fallback is used.
  2. Select the wallpaper-adaptive color mode and confirm that wallpaper polling starts.
  3. Open Settings.
  4. Click Restore Defaults and confirm the action.
  5. Use temporary logging, a debugger, or Process Monitor to observe the wallpaper registry queries.

Expected Behaviour

Restoring defaults should stop wallpaper polling because the default color mode is manual.

Actual Behaviour

The color mode resets to manual, but the existing wallpaper polling interval continues running every five seconds until the application exits or another settings change triggers polling reconciliation.

Technical Details

Normal settings updates call reconcileWallpaperPolling(), which stops the interval when wallpaper-adaptive mode is no longer active.

However, resetAllSettings() directly replaces the settings with their defaults and refreshes the application state without reconciling wallpaper polling.

Suggested Fix

Call reconcileWallpaperPolling() after resetting and saving the default settings in resetAllSettings().

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions