Description
Restoring default settings changes the color mode from wallpaper-adaptive to manual, but the main-process wallpaper polling interval remains active.
As a result, Paraline continues querying the Windows wallpaper registry every five seconds when the Node.js polling fallback was previously running.
resetAllSettings() replaces the current settings with the defaults but does not call reconcileWallpaperPolling() afterward.
Steps to Reproduce
- Run Paraline without a connected audio helper so that the Node.js wallpaper polling fallback is used.
- Select the wallpaper-adaptive color mode and confirm that wallpaper polling starts.
- Open Settings.
- Click Restore Defaults and confirm the action.
- Use temporary logging, a debugger, or Process Monitor to observe the wallpaper registry queries.
Expected Behaviour
Restoring defaults should stop wallpaper polling because the default color mode is manual.
Actual Behaviour
The color mode resets to manual, but the existing wallpaper polling interval continues running every five seconds until the application exits or another settings change triggers polling reconciliation.
Technical Details
Normal settings updates call reconcileWallpaperPolling(), which stops the interval when wallpaper-adaptive mode is no longer active.
However, resetAllSettings() directly replaces the settings with their defaults and refreshes the application state without reconciling wallpaper polling.
Suggested Fix
Call reconcileWallpaperPolling() after resetting and saving the default settings in resetAllSettings().
Description
Restoring default settings changes the color mode from wallpaper-adaptive to manual, but the main-process wallpaper polling interval remains active.
As a result, Paraline continues querying the Windows wallpaper registry every five seconds when the Node.js polling fallback was previously running.
resetAllSettings()replaces the current settings with the defaults but does not callreconcileWallpaperPolling()afterward.Steps to Reproduce
Expected Behaviour
Restoring defaults should stop wallpaper polling because the default color mode is
manual.Actual Behaviour
The color mode resets to
manual, but the existing wallpaper polling interval continues running every five seconds until the application exits or another settings change triggers polling reconciliation.Technical Details
Normal settings updates call
reconcileWallpaperPolling(), which stops the interval when wallpaper-adaptive mode is no longer active.However,
resetAllSettings()directly replaces the settings with their defaults and refreshes the application state without reconciling wallpaper polling.Suggested Fix
Call
reconcileWallpaperPolling()after resetting and saving the default settings inresetAllSettings().