Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
=========================================
- Coverage 80.7% 80.6% -0.1%
Complexity 135 135
=========================================
Files 16 16
Lines 570 568 -2
Branches 66 66
=========================================
- Hits 460 458 -2
Misses 69 69
Partials 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DavyLandman
reviewed
Apr 22, 2025
| if (os.contains("mac")) { | ||
| // OSX is SLOW on it's watches | ||
| delayFactor *= 2; | ||
| delayFactor *= 3; |
Member
There was a problem hiding this comment.
this makes the OS test a lot slower again.
In a different PR we should try and remove all the sleeps and replace them by accurate awaits. as the sleeps get very long, especially with a high delayFactor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
JDKFileWatch(which coincidentally came to light because of the new test, but isn't directly related to file moves) that caused events forfoo/bar/baz.txtto be reported as events forfoo/barandbaz.txtas root path and relative path, instead offoo/bar/baz.txtand(empty).