Turn previously disabled geometry tests back on#148
Conversation
PetrilloAtWork
left a comment
PetrilloAtWork
left a comment
There was a problem hiding this comment.
Perfect.
And belated congratulations for fixing the geometry!
|
trigger build |
|
CI build for LArSoft on slf7 for e20:prof is in progress -- details available through the CI dashboard |
|
CI build for LArSoft on slf7 for c7:prof is in progress -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
|
CI build for SBND on slf7 for e20:prof is in progress -- details available through the CI dashboard parent CI build details are available through the CI dashboard |
|
CI build for SBND on slf7 for c7:prof is in progress -- details available through the CI dashboard parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
4 participants
As per discussion in PR #141 it was noted (thanks @PetrilloAtWork) that there are a series of geometry tests within the unit tests for the CI which aren't active due to issues in the old geometry making them fail. I ran tests this morning with e20 and c7 in which the "new" tests all succeeded. I see no reason why we shouldn't reactivate these tests from now on!
There will be merge conflicts with this and the previously mentioned PR. We want to keep the changes from both i.e. remove all the lines that I remove here but add the line that is
"-WireIntersection"from the other PR. A further PR will be issued to remove this line as well once the issue in the geometry test has been solved by this.