Skip to content

Temporary fix for LArSoft View not correctly set #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pgreen135 merged 3 commits into from
Aug 16, 2021
Merged

Temporary fix for LArSoft View not correctly set #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
863c8c1
Swap plane 0 and plane 1 in TPC 0 only
marcodeltutto Aug 10, 2021
6b013d1
Temporarily disable geometry tests
henrylay97 Aug 11, 2021
380e579
Re-enable geometry tests, except the WireIntersection one
marcodeltutto Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sbndcode/Geometry/gdml/sbnd_v02_00.gdml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59227,11 +59227,11 @@
</physvol>
<physvol>
<volumeref ref="volTPCPlane_V"/>
<positionref ref="posVPlane_E"/>
<positionref ref="posUPlane_E"/> <!-- WARNING: this should be posV, will have to be fixed once LArSoft View is fixed -->
</physvol>
<physvol>
<volumeref ref="volTPCPlane_U"/>
<positionref ref="posUPlane_E"/>
<positionref ref="posVPlane_E"/> <!-- WARNING: this should be posU, will have to be fixed once LArSoft View is fixed -->
</physvol>
<physvol>
<volumeref ref="volTPCPlaneVert"/>
Expand Down
4 changes: 2 additions & 2 deletions sbndcode/Geometry/gdml/sbnd_v02_00_base.gdml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5690,11 +5690,11 @@

<physvol>
<volumeref ref="volTPCPlane_V"/>
<positionref ref="posVPlane_E"/>
<positionref ref="posUPlane_E"/> <!-- WARNING: this should be posV, will have to be fixed once LArSoft View is fixed -->
</physvol>
<physvol>
<volumeref ref="volTPCPlane_U"/>
<positionref ref="posUPlane_E"/>
<positionref ref="posVPlane_E"/> <!-- WARNING: this should be posU, will have to be fixed once LArSoft View is fixed -->
</physvol>
<physvol>
<volumeref ref="volTPCPlaneVert"/>
Expand Down
4 changes: 2 additions & 2 deletions sbndcode/Geometry/gdml/sbnd_v02_00_nowires.gdml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13531,11 +13531,11 @@
</physvol>
<physvol>
<volumeref ref="volTPCPlane_V"/>
<positionref ref="posVPlane_E"/>
<positionref ref="posUPlane_E"/> <!-- WARNING: this should be posV, will have to be fixed once LArSoft View is fixed -->
</physvol>
<physvol>
<volumeref ref="volTPCPlane_U"/>
<positionref ref="posUPlane_E"/>
<positionref ref="posVPlane_E"/> <!-- WARNING: this should be posU, will have to be fixed once LArSoft View is fixed -->
</physvol>
<physvol>
<volumeref ref="volTPCPlaneVert"/>
Expand Down
4 changes: 2 additions & 2 deletions sbndcode/Geometry/gdml/sbnd_v02_00_withshielding.gdml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59227,11 +59227,11 @@
</physvol>
<physvol>
<volumeref ref="volTPCPlane_V"/>
<positionref ref="posVPlane_E"/>
<positionref ref="posUPlane_E"/> <!-- WARNING: this should be posV, will have to be fixed once LArSoft View is fixed -->
</physvol>
<physvol>
<volumeref ref="volTPCPlane_U"/>
<positionref ref="posUPlane_E"/>
<positionref ref="posVPlane_E"/> <!-- WARNING: this should be posU, will have to be fixed once LArSoft View is fixed -->
</physvol>
<physvol>
<volumeref ref="volTPCPlaneVert"/>
Expand Down
4 changes: 2 additions & 2 deletions sbndcode/Geometry/gdml/sbnd_v02_00_withshielding_nowires.gdml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13531,11 +13531,11 @@
</physvol>
<physvol>
<volumeref ref="volTPCPlane_V"/>
<positionref ref="posVPlane_E"/>
<positionref ref="posUPlane_E"/> <!-- WARNING: this should be posV, will have to be fixed once LArSoft View is fixed -->
</physvol>
<physvol>
<volumeref ref="volTPCPlane_U"/>
<positionref ref="posUPlane_E"/>
<positionref ref="posVPlane_E"/> <!-- WARNING: this should be posU, will have to be fixed once LArSoft View is fixed -->
</physvol>
<physvol>
<volumeref ref="volTPCPlaneVert"/>
Expand Down
18 changes: 17 additions & 1 deletion test/Geometry/test_geometry_sbnd.fcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,20 @@ process_name: testGeo
services: {

@table::sbnd_geometry_services
Geometry: {
SurfaceY: 130.0e2 #in cm, vertical distance to the surface

Name: "sbndv1"
GDML: "sbnd_v01_05.gdml"
ROOT: "sbnd_v01_05.gdml"

SortingParameters: {
DetectorVersion: "sbnd"
}

SurfaceY: 0.0e2 #in cm, vertical distance to the surface
DisableWiresInG4: true
}

message: {
destinations: {
Expand Down Expand Up @@ -65,7 +79,9 @@ physics: {
"-NearestWire",
"-WirePitch",
# in addition (overriding the default): print wires
"+PrintWires"
"+PrintWires",
# Disable WireIntersection temporarily as known to fail
"-WireIntersection"
]

# wire pitch for planes #0, #1 and #2
Expand Down