Skip to content

Override larsoft and assign view using plane number for signal shape sim#128

Merged
pgreen135 merged 1 commit intoSBNSoftware:developfrom
wforeman:feature/wforeman_planeview_bugfix
Jul 29, 2021
Merged

Override larsoft and assign view using plane number for signal shape sim#128
pgreen135 merged 1 commit intoSBNSoftware:developfrom
wforeman:feature/wforeman_planeview_bugfix

Conversation

@wforeman
Copy link
Contributor

LArSoft is confusing the "View" (U/V/Y) for planes 0/1 in TPC 0 in the new geometry, resulting in the simulated signal shape being swapped for these two planes. The result is a ~10-fold increase in noise hits in tpc0/plane0 due to mis-matched signal shapes in the de-convolution stage. This fix simply overrides LArSoft's strange way of assigning the View, and instead explicitly uses the plane numbers (0=U, 1=V).

@pgreen135
Copy link
Member

trigger build

@FNALbuild
Copy link
Collaborator

CI build for LArSoft on slf7 for c7:prof is in progress -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

CI build for LArSoft on slf7 for e20:prof is in progress -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

CI build for SBND on slf7 for c7:prof is in progress -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

CI build for SBND on slf7 for e20:prof is in progress -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@pgreen135
Copy link
Member

now we see CI test differences as expected! @wforeman I presume these make sense? (e20, ignore the c7)

@pgreen135 pgreen135 self-requested a review July 29, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants