Override larsoft and assign view using plane number for signal shape sim#128
Conversation
|
trigger build |
|
CI build for LArSoft on slf7 for c7:prof is in progress -- details available through the CI dashboard |
|
CI build for LArSoft on slf7 for e20:prof is in progress -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
|
CI build for SBND on slf7 for c7:prof is in progress -- details available through the CI dashboard parent CI build details are available through the CI dashboard |
|
CI build for SBND on slf7 for e20:prof is in progress -- details available through the CI dashboard parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
now we see CI test differences as expected! @wforeman I presume these make sense? (e20, ignore the c7) |
LArSoft is confusing the "View" (U/V/Y) for planes 0/1 in TPC 0 in the new geometry, resulting in the simulated signal shape being swapped for these two planes. The result is a ~10-fold increase in noise hits in tpc0/plane0 due to mis-matched signal shapes in the de-convolution stage. This fix simply overrides LArSoft's strange way of assigning the View, and instead explicitly uses the plane numbers (0=U, 1=V).