Conversation
…tion is "bad channel aware" but otherwise same as before.
gputnam
approved these changes
May 9, 2025
gputnam
left a comment
gputnam
left a comment
There was a problem hiding this comment.
Approved. Discussions sorted out over slack.
Contributor
|
trigger build |
This was referenced May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small modifications that allow channels designated as "bad" (via the input selectvals array) to be skipped when computing coherent noise corrections.
The previous update had started to add a PCA based method for finding "signal" to protect on individual channels, now working.