der: Rudimentary implementation of TeletexString and VideotexString#691
Conversation
Fix the typo in printable_string.rs, which used PrintedString instead of PrintableString. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
|
Between all of the similar-but-not-identical string types this is starting to feel like quite a bit of duplication. Curious if this could be wrapped up in |
Add rudimentary TeletexString support. For the practical purposes the TeletexString is treated as IA5String, disallowing (for now) the chars from the non-ASCII space. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Add rudimentary VideotexString support. For the practical purposes the VideotexString is treated as IA5String, disallowing (for now) the chars from the non-ASCII space. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
As TeletexString got support, move the pkix_extensions/decode_idp test out of 'negative' are and check that parsing actually works. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
|
Updated to pass rustfmt. |
|
I pulled and ran a path validator against a set of busted certs that were discussed a few months back (some of which had teletex). Those now parse and validate. I don't recall why we didn't pursue this approach (other than maybe that teletex is more or less deprecated by 5280). |
|
I'm going to take a look at some approaches to removing duplication before I cut a release with this.
@carl-wallace last I recall we were talking about |
|
@carl-wallace as you've mentioned it. I couldn't find an existing pki/path validation library/code using x509-cert. Could you hopefully point me to it? |
|
Bear in mind it’s not “done” and I’ve not worked with it other than quick tests like this for a few months, but I have thrown a variety of certs collected from the wild at it. If you find it useful, I’d welcome additional hands to ready for release. It’s here: https://github.com/carl-wallace/rust-pki. Note, I have some unpushed changes to add p384 support once that is released.
From: Dmitry Baryshkov ***@***.***>
Reply-To: RustCrypto/formats ***@***.***>
Date: Friday, July 29, 2022 at 6:32 PM
To: RustCrypto/formats ***@***.***>
Cc: Carl Wallace ***@***.***>, Mention ***@***.***>
Subject: Re: [RustCrypto/formats] der: Rudimentary implementation of TeletexString and VideotexString (PR #691)
@carl-wallace as you've mentioned it. I couldn't find an existing pki/path validation library/code using x509-cert. Could you hopefully point me to it?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
3 participants
Add basic support for TeletexString and VideotexString tags. For now treat them as if they were IA5Strings, disallowing chars >= 0x80.