Skip to content

Correctly format email addresses. #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baloo merged 2 commits into from
Jun 3, 2024
Merged

Correctly format email addresses. #1425

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b020d5d
Correctly format email addresses.
Jun 3, 2024
c0077ab
Remove unnecessary OID synonym
Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions x509-cert/src/attr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

use alloc::vec::Vec;
use const_oid::db::{
rfc3280::EMAIL_ADDRESS,
rfc4519::{COUNTRY_NAME, DOMAIN_COMPONENT, SERIAL_NUMBER},
Database, DB,
};
Expand Down Expand Up @@ -191,6 +192,9 @@ impl AttributeTypeAndValue {
// Serial numbers are formatted as Printable String as per RFC 5280 Appendix A.1:
// https://datatracker.ietf.org/doc/html/rfc5280#appendix-A.1
SERIAL_NUMBER => Tag::PrintableString,
// Email addresses are formatted as Ia5String as per RFC 5280 Appendix A.1:
// https://datatracker.ietf.org/doc/html/rfc5280#appendix-A.1
EMAIL_ADDRESS => Tag::Ia5String,
_ => Tag::Utf8String,
};

Expand Down