fix(#1210): fix impl of SubjectDirectoryAttributes#1211
Closed
Taowyoo wants to merge 1 commit into
Closed
Conversation
Member
|
Though this does appear to be a bug, it's also a breaking change to incorporate the fix. We can merge it as part of the next development cycle when we're making breaking changes. |
Contributor
Author
|
sounds good |
Member
|
@Taowyoo We’re still interested in this, FYI |
Contributor
Author
|
Hi @tarcieri, thank you for reminding me. I accidentally close this PR when cleaning repositories. I will create another one with same commit soon. |
Contributor
Author
|
^^^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1210