Repository navigation
Conversation
|
This adds a nearly identical copy of the sine example. Wouldn't it be more elegant to just let the ci compile the existing example? |
Yeah, I'm probably gonna remove that integration test. My understanding is that |
|
Can't we just let the ci run the examples? Like If one of them fails that should fail the job. |
Oh there's not really a good reason. The OCD in me says "Because an example is not a test and CI is for tests". I took your advice and added the the example run to CI. Anyway, @HEnquist I bumped the version to |
|
Looks great! |
It's not really. I mostly went with it to be consistent with the ci in coreaudio-sys and use an explicit version of LLVM. The existing llvm install parts use At some point it'd be good to test multiple version of llvm to avoid things like RustAudio/coreaudio-sys#85. |
Follow up from #109.