test: prove signup logs redact private data - #147
Merged
Conversation
✅ Deploy Preview for luminous-fox-7c393f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
The existing fixed signup failure message now has hostile-canary regression coverage. The test proves a successful signup emits no error log, while a failed profile transaction emits exactly one fixed phrase and returns only the existing generic error.
Tracks #146. Parent tracker: #111.
Security invariant and failure behavior
console.errorarguments or the returned error code/message.console.debug,error,info,log, orwarncall.Member profile setup failed during account creation.and the existinginternal/Failed to create member recordresponse.console.debug,info,log, andwarnremain silent.Scope
functions/ensureMemberProfile.test.jsonlyNo runtime, dependency, schema, frontend, Rules, workflow, root-document, officer-guide, provider, production-data, or sitemap change.
Test evidence
Node 20.20.2 on exact head
329b58808b8e09d0f284c2f6b7369920aa6afdc6, basef2caaae3b3f25adfd4fc552008871408f18e5931:ensureMemberProfile.test.js: 1 suite / 20 tests passed.git diff --check: passed.console.error; the final version closes that gap across all five standard console levels.29246004213passed frontend, Functions, and Firestore Rules on this exact head.e3a40a405ffaa79d1cffdbfd336e27edeae20e986f8e2ea4f24fc16abce14ff6.Tests use the existing Firebase Admin/Functions mocks and synthetic values. They make no Firebase or outside-provider call.
Compatibility / rollback
Runtime behavior is byte-for-byte unchanged. Removing this test would remove regression proof but would not change deployed behavior.
Officer impact: None — member and officer tasks/screens are unchanged.
Officer documentation: None — no procedure, navigation, permission, collected field, deployment duty, or external account changed.
Deployment evidence:
runmprc.comverification: not performed; no exact revision is claimed live.