OBS-001A2: disable unapproved Firebase Analytics collection - #141
Merged
Conversation
✅ Deploy Preview for luminous-fox-7c393f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
6 tasks
daliu
force-pushed
the
codex/issue-139-disable-analytics
branch
from
July 13, 2026 10:42
1ceee3d to
da7da35
Compare
daliu
marked this pull request as ready for review
July 13, 2026 10:44
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Firebase Analytics is disabled in application source pending an approved #110 privacy policy. No runtime source imports the Analytics SDK,
FirebaseResources.analyticsis permanentlynull, the existingtrack(...)API is a provider-free compatibility no-op, and the Waiver page no longer bypasses that boundary. This describes source behavior only; it does not claim the website or provider state changed.Tracks #139. Parent tracker: #111.
Security invariant and failure behavior
firebase/analytics,isSupported,getAnalytics, orlogEvent.srcguard.Scope
src/services/analytics/analytics.tssrc/services/analytics/analytics.test.tssrc/services/firebase/FirebaseResources.tssrc/services/firebase/FirebaseResources.test.tssrc/pages/joinUs/Waiver.jsxSYSTEM_DESIGN.mdSECURITY.mdOPERATIONS_RUNBOOK.mdExcluded: Sentry, signup/profile/Auth, Firestore Rules, Stripe/webhook, Strava, sitemap, provider consoles, production data, cookies/storage deletion, and privacy-policy decisions.
Test evidence
Node 20.20.2 on exact head
da7da350a1cc0be876e710e3432e3d7966272617, rebased onto non-overlapping #101 merge87bd1210575882cdd06214bcb98ed38ce00f71c2:--max-warnings=0: passed.git diff --check: passed..mjsmodules and public HTML/JavaScript entrypoints. Exact headda7da350a1cc0be876e710e3432e3d7966272617adds negative fixtures plus an enumeration regression coveringsrc.mjsand every executablepublicsurface. Exact-head privacy, regression, and SDK/build reviews all approve the final fingerprint. Hosted CI run29243696803passed Cloud Functions, frontend, and Firestore Rules on this exact head. Final diff SHA-256:c29e1525f1c4cc5a317a00ead88a3368434c7879b88e1b453c30e1996a63fc35.Tests use mocks, source inspection, and synthetic privacy canaries. They make no Firebase Analytics or other provider call.
Compatibility / rollback
No dependency, schema, route, storage, or provider configuration changes. Existing event constants and
track(eventName, params)call signatures remain source-compatible. Waiver still recordswaiverSigned=trueand invokes its callback; the label/input association is made explicit. Rollback would restore unapproved collection and requires privacy review.Officer impact
None — no officer/member procedure, navigation, permission, or collected field changes.
Officer documentation
None — this is an internal telemetry containment boundary. The system diagram and engineering security/operations evidence are updated; no officer task guide changed.
Deployment evidence
da7da350a1cc0be876e710e3432e3d7966272617is pushed and independently approved; not merged.runmprc.comverification: not performed; no exact revision is claimed live.