OBS-001A1: fail closed for Sentry personal data - #137
Merged
Conversation
✅ Deploy Preview for luminous-fox-7c393f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
7 tasks
Contributor
Author
|
Hosted draft verification for exact source commit
Existing repository lint annotations outside this two-file scope remain warnings only. The PR stays draft pending the explicit shared-document release and a refresh from the resulting |
daliu
force-pushed
the
codex/issue-134-sentry-redaction
branch
from
July 13, 2026 10:09
0ea0fcb to
2399de6
Compare
daliu
marked this pull request as ready for review
July 13, 2026 10:23
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
The frontend Sentry source now fails closed for member data: session replay, tracing, browser sessions, client reports, breadcrumbs, attachments, user identity, and unknown integrations are disabled or removed before transport. Only generic error classes, tightly bounded CRA bundle locations, and strictly validated non-content event metadata remain. This wording describes the branch source, not deployed behavior.
#135 and #118 are merged. This branch is rebased on resulting
maincommit13ccc1b67dd57f69091e808b12e1287a1bc05b2fand includes the releasedSECURITY.md/OPERATIONS_RUNBOOK.mdstatus updates. Exact final-head hosted CI and both follow-up reviews are complete.Tracks #134. Parent tracker: #111. Keep #134 open after merge until the affected release surfaces are recorded truthfully.
Security invariant and failure behavior
GlobalHandlersandTryCatchsurvive the default-integration allowlist; every unknown future default drops.Scope
src/services/monitoring/sentry.tssrc/services/monitoring/sentry.test.tsSECURITY.md(one remediation-ledger row)OPERATIONS_RUNBOOK.md(one evidence-boundary paragraph)Excluded: Analytics,
functions/signup.js, Auth/profile code, Firestore Rules, Stripe/webhook, Strava, sitemap, external Sentry settings, and all #118 runtime/profile paths. #118 merged the separate signup-log slice as source only; its provider deployment remains unproven.Test evidence
Node 20.20.2 on exact final head
a0c9065635046c948f1ba92fdf1fe8175b693c40:--max-warnings=0: passed.git diff --check: passed.a0c9065635046c948f1ba92fdf1fe8175b693c40fixes those findings; both follow-up reviewers approved that exact head with no remaining blocker. The final diff SHA-256 is7aa64a7636e9257f457002978d6783747c2e459abbce477652df77efa6cd24ee.29242490328passed frontend tests/callback and release gates/build, Functions lint/tests, and Firestore Rules on that exact head. Netlify's exact-head preview completed, but is not production evidence.Tests mock Sentry and use synthetic canaries only. They make no Firebase, Sentry, or other provider call.
Compatibility / rollback
No schema, route, dependency, provider, or API change. Existing ErrorBoundary capture remains. Rollback is the single source commit; doing so would restore the known PII/replay exposure and therefore requires a security review.
Officer impact
None — no officer/member procedure, navigation, permission, or collected field changes.
Officer documentation
None — this is an internal telemetry safety boundary. Engineering evidence boundaries are updated in
SECURITY.mdandOPERATIONS_RUNBOOK.md; no officer task guide changed.Deployment evidence
a0c9065635046c948f1ba92fdf1fe8175b693c40is committed and pushed; not merged.