[Fix] Sandbox yarn PATH and --no-verify git push delivery - #933
Closed
pridemusvaire wants to merge 2 commits into
Closed
[Fix] Sandbox yarn PATH and --no-verify git push delivery#933pridemusvaire wants to merge 2 commits into
pridemusvaire wants to merge 2 commits into
Conversation
Enable Corepack yarn on the worker PATH and push with --no-verify in delivery skills so husky pre-push suites do not block Roomote sandbox delivery or get misreported as missing GitLab credentials.
pridemusvaire
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
July 31, 2026 05:45
Contributor
Knip flagged them as unlisted after Corepack yarn enablement; they are runtime worker tools, not package dependencies.
Contributor
Author
|
Closing: not merging upstream. The sandbox yarn PATH + |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yarnis on PATH for husky pre-push hooks in sandboxes.push,create-pr,create-draft-pr,fix-pr, merge-conflict resolver, environment-setup) to push with--no-verify, since CI owns full-suite pre-push checks and sandbox hook failures were being misreported as missing GitLab credentials.Root cause
GitLab OAuth/source-control proxy credentials were fine. Pushes failed because fleet-portal's
.husky/pre-pushrequiresyarn, which was not on the sandbox PATH (yarn: not found), and agents narrated that as a credential outage.Test plan
pnpm --filter @roomote/worker exec vitest run src/commands/setup/__tests__/mise.test.ts--no-verify) and open MR viamanage_source_control