[Feat] Enable PR review notifications for everyone - #60
Merged
mrubens merged 3 commits intoJul 10, 2026
Conversation
Remove the PrReviewNotifications feature flag so conversation-backed tasks always receive idle-time PR review feedback notifications.
The helper was only used by the removed PrReviewNotifications gate.
Author
|
No new code issues found. See task
|
Author
|
Fixed the comma splice in Pushed in cb8f6bf. |
Split the redis-queues guidance into two sentences after the flag removal left a comma splice.
mrubens
marked this pull request as ready for review
July 10, 2026 03:49
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
July 10, 2026 03:49
mrubens
pushed a commit
that referenced
this pull request
Jul 10, 2026
- #60 (PR review notifications for everyone): kept develop's removal of the feature-flag gate, expressed with our task_runs naming - doc frontmatter and model-recommendation conflicts resolved trivially
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PR review notifications are now always on. The experimental
PrReviewNotificationsfeature flag is removed, so conversation-backed tasks that own a PR get idle-time notification of non-mention review feedback without needing a deployment metadata toggle.Enqueues and BullMQ delivery no longer re-check that flag; the leftover flag-only helper is gone; admin/config surfaces and agent guidance no longer list the flag. A follow-up docs fix splits the PR Review Notification Queue description in
redis-queues.mdinto proper sentences after the flag clause was removed.Why this change was made
The feature is ready to ship for everyone. Keeping it behind an opt-in flag left deployments on the off default unless operators flipped metadata, and the dual enqueue/delivery gates added complexity once the default should be always-on.
Impact
Review feedback on task-owned PRs will notify the originating Slack, Teams, or Telegram thread once the task is idle for every deployment — no metadata enablement step. There is no longer a way to turn the relay off via feature flag. Existing linked/open-PR routing, idle deferral, and not-worth-notifying filters are unchanged.